Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/NativeScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.2.1
Choose a base ref
...
head repository: NativeScript/NativeScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.2.2
Choose a head ref
  • 8 commits
  • 33 files changed
  • 5 contributors

Commits on Nov 14, 2019

  1. fix(android): Fatal Exception: java.lang.OutOfMemoryError (#8061) (#8098

    )
    
    Crashlytics:
    **Async.java line 181**
    **org.nativescript.widgets.Async$Image$DownloadImageTask.doInBackground**
    ```
    Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 3601932 byte allocation with 970044 free bytes and 947KB until OOM
    at dalvik.system.VMRuntime.newNonMovableArray(VMRuntime.java)
    at android.graphics.BitmapFactory.nativeDecodeStream(BitmapFactory.java)
    at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:863)
    at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:839)
    at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:877)
    at org.nativescript.widgets.Async$Image$DownloadImageTask.doInBackground(Async.java:181)
    at org.nativescript.widgets.Async$Image$4.run(Async.java:157)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
    at org.nativescript.widgets.Async$PriorityThreadFactory$1.run(Async.java:86)
    at java.lang.Thread.run(Thread.java:818)
    ```
    
    Crashlytics
    **Async.java line 473**
    **org.nativescript.widgets.Async$Http$RequestResult.readResponseStream**
    ```
    Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 3000012 byte allocation with 2043950 free bytes and 1996KB until OOM
           at dalvik.system.VMRuntime.newNonMovableArray(VMRuntime.java)
           at android.graphics.BitmapFactory.nativeDecodeByteArray(BitmapFactory.java)
           at android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:744)
           at org.nativescript.widgets.Async$Http$RequestResult.readResponseStream(Async.java:473)
           at org.nativescript.widgets.Async$Http$HttpRequestTask.doInBackground(Async.java:555)
           at org.nativescript.widgets.Async$Http$1.run(Async.java:307)
           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
           at org.nativescript.widgets.Async$PriorityThreadFactory$1.run(Async.java:86)
           at java.lang.Thread.run(Thread.java:818)
    ```
    
    ## PR Checklist
    
    - [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
    - [x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
    - [x] You have signed the [CLA](http://www.nativescript.org/cla).
    - [x] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
    - [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.
    
    ## What is the current behavior?
    Uncaught exception resulting in crash. This was introduced in v6.2.0.
    
    ## What is the new behavior?
    Additional `catch` block for uncaught exception type `OutOfMemoryError`
    
    Fixes:
    https://www.telerik.com/account/support-tickets/view-ticket/1436458
    manoldonev authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bca1271 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d983f79 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Configuration menu
    Copy the full SHA
    b069ff3 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Configuration menu
    Copy the full SHA
    800f5bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    786aca3 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Configuration menu
    Copy the full SHA
    47f4c25 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Configuration menu
    Copy the full SHA
    dd09de3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8138 from NativeScript/release-6.2.2

    chore: cut the 6.2.2 release
    dtopuzov authored Nov 26, 2019
    Configuration menu
    Copy the full SHA
    2b1fab3 View commit details
    Browse the repository at this point in the history
Loading