chore: updated ui sample to work with latest ObservableArray changes (#10065)

CatchABus · web-flow · commit e2c2f1f4a66c · 2022-10-23T15:05:06.000-07:00
diff --git a/apps/ui/src/main-page-view-model.ts b/apps/ui/src/main-page-view-model.ts
@@ -70,9 +70,11 @@ export class MainPageViewModel extends TestPageMainViewModel {
 
 	private filterListView(value: string) {
 		if (!MainPageViewModel.checkIfStringIsNullEmptyOrUndefined(value)) {
-			let array = MainPageViewModel.ALL_EXAMPLES.filter((testExample, index, array) => {
-				return MainPageViewModel.stringContains(testExample.path.toLowerCase(), value.toLowerCase()) || MainPageViewModel.stringContains(testExample.name.toLowerCase(), value.toLowerCase());
-			});
+			let array = Array.from(
+				MainPageViewModel.ALL_EXAMPLES.filter((testExample, index, array) => {
+					return MainPageViewModel.stringContains(testExample.path.toLowerCase(), value.toLowerCase()) || MainPageViewModel.stringContains(testExample.name.toLowerCase(), value.toLowerCase());
+				})
+			);
 			this.filteredListOfExamples = new ObservableArray(array);
 		} else {
 			this.filteredListOfExamples = null;
diff --git a/apps/ui/src/search-bar/issue-5039-view-model.ts b/apps/ui/src/search-bar/issue-5039-view-model.ts
@@ -20,7 +20,8 @@ export class Issue5039ViewModel extends Observable {
 	}
 
 	filter(value: string = '') {
+		const filteredItems = this._items.filter((item) => -1 !== item.indexOf(value));
 		this.items.splice(0, this.items.length); // remove all items
-		this.items.push(this._items.filter((i) => -1 !== i.indexOf(value)));
+		this.items.push(...filteredItems);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,8 @@ export class Issue5039ViewModel extends Observable {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`filter(value: string = '') {`
	`23`	`+ const filteredItems = this._items.filter((item) => -1 !== item.indexOf(value));`
`23`	`24`	`this.items.splice(0, this.items.length); // remove all items`
`24`		`- this.items.push(this._items.filter((i) => -1 !== i.indexOf(value)));`
	`25`	`+ this.items.push(...filteredItems);`
`25`	`26`	`}`
`26`	`27`	`}`