fix(tabs-android): wrong tabStripItem selected (#7522)

ADjenkov · web-flow · commit ca22ba93911f · 2019-07-16T10:18:01.000+03:00
diff --git a/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/TabLayout.java b/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/TabLayout.java
@@ -383,7 +383,11 @@ public void onPageScrolled(int position, float positionOffset, int positionOffse
             }
 
             int prevPosition = mTabStrip.getSelectedPosition();
-            onSelectedPositionChange(position, prevPosition);
+
+            if (prevPosition != position) {
+                onSelectedPositionChange(position, prevPosition);
+            }
+
             mTabStrip.onViewPagerPageChanged(position, positionOffset);
 
             View selectedTitle = mTabStrip.getChildAt(position);
diff --git a/tns-core-modules/ui/tabs/tabs.android.ts b/tns-core-modules/ui/tabs/tabs.android.ts
@@ -248,18 +248,14 @@ function initializeNativeClasses() {
                 return;
             }
 
-            if (position !== prevPosition) {
-                const tabStripItems = owner.tabStrip && owner.tabStrip.items;
-
-                if (position >= 0 && tabStripItems && tabStripItems[position]) {
-                    tabStripItems[position]._emit(TabStripItem.selectEvent);
-                }
+            const tabStripItems = owner.tabStrip && owner.tabStrip.items;
 
-                if (prevPosition >= 0 && tabStripItems && tabStripItems[prevPosition]) {
-                    tabStripItems[prevPosition]._emit(TabStripItem.unselectEvent);
-                }
+            if (position >= 0 && tabStripItems && tabStripItems[position]) {
+                tabStripItems[position]._emit(TabStripItem.selectEvent);
+            }
 
-                owner.selectedIndex = position;
+            if (prevPosition >= 0 && tabStripItems && tabStripItems[prevPosition]) {
+                tabStripItems[prevPosition]._emit(TabStripItem.unselectEvent);
             }
         }
 
