Repository navigation
Commit bca1271
authored
Crashlytics:
**Async.java line 181**
**org.nativescript.widgets.Async$Image$DownloadImageTask.doInBackground**
```
Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 3601932 byte allocation with 970044 free bytes and 947KB until OOM
at dalvik.system.VMRuntime.newNonMovableArray(VMRuntime.java)
at android.graphics.BitmapFactory.nativeDecodeStream(BitmapFactory.java)
at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:863)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:839)
at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:877)
at org.nativescript.widgets.Async$Image$DownloadImageTask.doInBackground(Async.java:181)
at org.nativescript.widgets.Async$Image$4.run(Async.java:157)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at org.nativescript.widgets.Async$PriorityThreadFactory$1.run(Async.java:86)
at java.lang.Thread.run(Thread.java:818)
```
Crashlytics
**Async.java line 473**
**org.nativescript.widgets.Async$Http$RequestResult.readResponseStream**
```
Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 3000012 byte allocation with 2043950 free bytes and 1996KB until OOM
at dalvik.system.VMRuntime.newNonMovableArray(VMRuntime.java)
at android.graphics.BitmapFactory.nativeDecodeByteArray(BitmapFactory.java)
at android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:744)
at org.nativescript.widgets.Async$Http$RequestResult.readResponseStream(Async.java:473)
at org.nativescript.widgets.Async$Http$HttpRequestTask.doInBackground(Async.java:555)
at org.nativescript.widgets.Async$Http$1.run(Async.java:307)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at org.nativescript.widgets.Async$PriorityThreadFactory$1.run(Async.java:86)
at java.lang.Thread.run(Thread.java:818)
```
## PR Checklist
- [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
- [x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
- [x] You have signed the [CLA](http://www.nativescript.org/cla).
- [x] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.
## What is the current behavior?
Uncaught exception resulting in crash. This was introduced in v6.2.0.
## What is the new behavior?
Additional `catch` block for uncaught exception type `OutOfMemoryError`
Fixes:
https://www.telerik.com/account/support-tickets/view-ticket/1436458
1 parent 1528498 commit bca1271
1 file changed
Lines changed: 4 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
| 183 | + | |
| 184 | + | |
188 | 185 | | |
189 | 186 | | |
190 | 187 | | |
| |||
472 | 469 | | |
473 | 470 | | |
474 | 471 | | |
475 | | - | |
476 | | - | |
| 472 | + | |
| 473 | + | |
477 | 474 | | |
478 | 475 | | |
479 | 476 | | |
| |||
0 commit comments