refactor(Async): update onError of CompleteCallback interface (#149)

vchimev · web-flow · commit a307295d6fca · 2018-12-12T12:48:29.000+02:00
* refactor(Async): update onError of CompleteCallback interface

Include the error that occurs.

* refactor(Async): swap onError parameters
diff --git a/android/widgets/src/main/java/org/nativescript/widgets/Async.java b/android/widgets/src/main/java/org/nativescript/widgets/Async.java
@@ -56,7 +56,7 @@ static ThreadPoolExecutor threadPoolExecutor() {
     public interface CompleteCallback {
         void onComplete(Object result, Object tag);
 
-        void onError(Object tag);
+        void onError(String error, Object tag);
     }
 
     static class PriorityThreadFactory implements ThreadFactory {
@@ -194,7 +194,7 @@ protected void onPostExecute(final Bitmap result) {
                 if (result != null) {
                     this.callback.onComplete(result, this.context);
                 } else {
-                    this.callback.onError(this.context);
+                    this.callback.onError("DownloadImageTask returns no result.", this.context);
                 }
             }
         }
@@ -227,7 +227,7 @@ protected void onPostExecute(final Bitmap result) {
                 if (result != null) {
                     this.callback.onComplete(result, this.requestId);
                 } else {
-                    this.callback.onError(this.requestId);
+                    this.callback.onError("LoadImageFromResourceTask returns no result.", this.requestId);
                 }
             }
         }
@@ -250,7 +250,7 @@ protected void onPostExecute(final Bitmap result) {
                 if (result != null) {
                     this.callback.onComplete(result, this.requestId);
                 } else {
-                    this.callback.onError(this.requestId);
+                    this.callback.onError("LoadImageFromFileTask returns no result.", this.requestId);
                 }
             }
         }
@@ -274,7 +274,7 @@ protected void onPostExecute(final Bitmap result) {
                 if (result != null) {
                     this.callback.onComplete(result, this.requestId);
                 } else {
-                    this.callback.onError(this.requestId);
+                    this.callback.onError("LoadImageFromBase64StringTask returns no result.", this.requestId);
                 }
             }
         }
@@ -572,7 +572,7 @@ protected void onPostExecute(final RequestResult result) {
                 if (result != null) {
                     this.callback.onComplete(result, this.context);
                 } else {
-                    this.callback.onError(this.context);
+                    this.callback.onError("HttpRequestTask returns no result.", this.context);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ static ThreadPoolExecutor threadPoolExecutor() {`
`56`	`56`	`public interface CompleteCallback {`
`57`	`57`	`void onComplete(Object result, Object tag);`
`58`	`58`
`59`		`- void onError(Object tag);`
	`59`	`+ void onError(String error, Object tag);`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`static class PriorityThreadFactory implements ThreadFactory {`
`@@ -194,7 +194,7 @@ protected void onPostExecute(final Bitmap result) {`
`194`	`194`	`if (result != null) {`
`195`	`195`	`this.callback.onComplete(result, this.context);`
`196`	`196`	`} else {`
`197`		`- this.callback.onError(this.context);`
	`197`	`+ this.callback.onError("DownloadImageTask returns no result.", this.context);`
`198`	`198`	`}`
`199`	`199`	`}`
`200`	`200`	`}`
`@@ -227,7 +227,7 @@ protected void onPostExecute(final Bitmap result) {`
`227`	`227`	`if (result != null) {`
`228`	`228`	`this.callback.onComplete(result, this.requestId);`
`229`	`229`	`} else {`
`230`		`- this.callback.onError(this.requestId);`
	`230`	`+ this.callback.onError("LoadImageFromResourceTask returns no result.", this.requestId);`
`231`	`231`	`}`
`232`	`232`	`}`
`233`	`233`	`}`
`@@ -250,7 +250,7 @@ protected void onPostExecute(final Bitmap result) {`
`250`	`250`	`if (result != null) {`
`251`	`251`	`this.callback.onComplete(result, this.requestId);`
`252`	`252`	`} else {`
`253`		`- this.callback.onError(this.requestId);`
	`253`	`+ this.callback.onError("LoadImageFromFileTask returns no result.", this.requestId);`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`	`}`
`@@ -274,7 +274,7 @@ protected void onPostExecute(final Bitmap result) {`
`274`	`274`	`if (result != null) {`
`275`	`275`	`this.callback.onComplete(result, this.requestId);`
`276`	`276`	`} else {`
`277`		`- this.callback.onError(this.requestId);`
	`277`	`+ this.callback.onError("LoadImageFromBase64StringTask returns no result.", this.requestId);`
`278`	`278`	`}`
`279`	`279`	`}`
`280`	`280`	`}`
`@@ -572,7 +572,7 @@ protected void onPostExecute(final RequestResult result) {`
`572`	`572`	`if (result != null) {`
`573`	`573`	`this.callback.onComplete(result, this.context);`
`574`	`574`	`} else {`
`575`		`- this.callback.onError(this.context);`
	`575`	`+ this.callback.onError("HttpRequestTask returns no result.", this.context);`
`576`	`576`	`}`
`577`	`577`	`}`
`578`	`578`