fix: added null guard

vtrifonov · vtrifonov · commit 9d4e482b3896 · 2020-03-06T14:35:57.000+02:00
diff --git a/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/BottomNavigationBar.java b/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/BottomNavigationBar.java
@@ -243,13 +243,15 @@ public void onSelectedPositionChange(int position, int prevPosition) {
     }
 
     private void setImageHeights(){
-        for (TabItemSpec tabItem : this.mTabItems) {
-            if(tabItem.imageHeight == 0 && tabItem.iconId != 0) {
-                Drawable drawable = getResources().getDrawable(tabItem.iconId);
-                tabItem.imageHeight = drawable.getIntrinsicHeight();
-            }
-            if(tabItem.imageHeight > this.mMaxImageHeight) {
-                this.mMaxImageHeight = tabItem.imageHeight;
+        if (this.mTabItems != null) {
+            for (TabItemSpec tabItem : this.mTabItems) {
+                if(tabItem.imageHeight == 0 && tabItem.iconId != 0) {
+                    Drawable drawable = getResources().getDrawable(tabItem.iconId);
+                    tabItem.imageHeight = drawable.getIntrinsicHeight();
+                }
+                if(tabItem.imageHeight > this.mMaxImageHeight) {
+                    this.mMaxImageHeight = tabItem.imageHeight;
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -243,13 +243,15 @@ public void onSelectedPositionChange(int position, int prevPosition) {`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`private void setImageHeights(){`
`246`		`- for (TabItemSpec tabItem : this.mTabItems) {`
`247`		`- if(tabItem.imageHeight == 0 && tabItem.iconId != 0) {`
`248`		`- Drawable drawable = getResources().getDrawable(tabItem.iconId);`
`249`		`- tabItem.imageHeight = drawable.getIntrinsicHeight();`
`250`		`- }`
`251`		`- if(tabItem.imageHeight > this.mMaxImageHeight) {`
`252`		`- this.mMaxImageHeight = tabItem.imageHeight;`
	`246`	`+ if (this.mTabItems != null) {`
	`247`	`+ for (TabItemSpec tabItem : this.mTabItems) {`
	`248`	`+ if(tabItem.imageHeight == 0 && tabItem.iconId != 0) {`
	`249`	`+ Drawable drawable = getResources().getDrawable(tabItem.iconId);`
	`250`	`+ tabItem.imageHeight = drawable.getIntrinsicHeight();`
	`251`	`+ }`
	`252`	`+ if(tabItem.imageHeight > this.mMaxImageHeight) {`
	`253`	`+ this.mMaxImageHeight = tabItem.imageHeight;`
	`254`	`+ }`
`253`	`255`	`}`
`254`	`256`	`}`
`255`	`257`	`}`