fix(android-list-picker): NoSuchFieldException on api29 (#7790)

manoldonev · web-flow · commit 997d6de2e3ff · 2019-09-10T13:38:38.000+03:00
diff --git a/tns-core-modules/ui/list-picker/list-picker.android.ts b/tns-core-modules/ui/list-picker/list-picker.android.ts
@@ -1,8 +1,12 @@
 import { ListPickerBase, selectedIndexProperty, itemsProperty, colorProperty, Color } from "./list-picker-common";
 import { ItemsSource } from ".";
+import { device } from "../../platform";
+import lazy from "../../utils/lazy";
 
 export * from "./list-picker-common";
 
+const sdkVersion = lazy(() => parseInt(device.sdkVersion));
+
 interface Formatter {
     new (owner: ListPicker): android.widget.NumberPicker.Formatter;
 }
@@ -90,7 +94,14 @@ export class ListPicker extends ListPickerBase {
         super.initNativeView();
         initializeNativeClasses();
         const nativeView = this.nativeViewProtected;
-        this._selectorWheelPaint = getSelectorWheelPaint(nativeView);
+
+        // api28 and lower uses reflection to retrieve and manipulate 
+        // android.graphics.Paint object; this is no longer allowed on newer api levels but
+        // equivalent public methods are exposed on api29+ directly on the native widget
+        if (sdkVersion() < 29) {
+            this._selectorWheelPaint = getSelectorWheelPaint(nativeView);
+        }
+
         const formatter = new Formatter(this);
         nativeView.setFormatter(formatter);
         (<any>nativeView).formatter = formatter;
@@ -153,28 +164,33 @@ export class ListPicker extends ListPickerBase {
         selectedIndexProperty.coerce(this);
     }
 
-    [colorProperty.getDefault](): { wheelColor: number, textColor: number } {
-    const editText = (<any>this.nativeViewProtected).editText;
+    [colorProperty.getDefault](): number {
+        // api28 and lower uses reflection to retrieve and manipulate 
+        // android.graphics.Paint object; this is no longer allowed on newer api levels but
+        // equivalent public methods are exposed on api29+ directly on the native widget
+        if (this._selectorWheelPaint) {
+            return this._selectorWheelPaint.getColor();
+        }
 
-    return {
-            wheelColor: this._selectorWheelPaint.getColor(),
-            textColor: editText ? editText.getTextColors().getDefaultColor() : -1
-        };
+        return this.nativeView.getTextColor();
     }
-    [colorProperty.setNative](value: { wheelColor: number, textColor: number } | Color) {
-        let color: number;
-        let wheelColor: number;
-        if (value instanceof Color) {
-            color = wheelColor = value.android;
+    [colorProperty.setNative](value: number | Color) {
+        const color = value instanceof Color ? value.android : value;
+
+        // api28 and lower uses reflection to retrieve and manipulate 
+        // android.graphics.Paint object; this is no longer allowed on newer api levels but
+        // equivalent public methods are exposed on api29+ directly on the native widget
+        if (this._selectorWheelPaint) {
+            this._selectorWheelPaint.setColor(color);
+
+            const editText = (<any>this.nativeViewProtected).editText;
+            if (editText) {
+                editText.setTextColor(color);
+            }
         } else {
-            color = value.textColor;
-            wheelColor = value.wheelColor;
-        }
-
-        this._selectorWheelPaint.setColor(wheelColor);
-        const editText = (<any>this.nativeViewProtected).editText;
-        if (editText) {
-            editText.setTextColor(color);
+            // api29 and higher native implementation sets
+            // both wheel color and input text color with single call
+            this.nativeView.setTextColor(color);
         }
     }
 }
