Skip to content

Commit 6daba69

Browse files
SvetoslavTsenovSvetoslavTsenov
authored
Merge pull request #6584 from NativeScript/release-5.0.3
docs: cut the 5.0.3 release
2 parents ed2e908 + d703f7a commit 6daba69

35 files changed

Lines changed: 661 additions & 60 deletions

‎CHANGELOG.md‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,29 @@
1-
Cross Platform Modules Changelog
2-
==============================
1+
<a name="5.0.3"></a>
2+
## [5.0.3](https://github.com/NativeScript/NativeScript/compare/5.0.2...5.0.3) (2018-11-20)
3+
4+
5+
### Bug Fixes
6+
7+
* crash on Android Tab-View [#6466](https://github.com/NativeScript/NativeScript/issues/6466) ([#6467](https://github.com/NativeScript/NativeScript/issues/6467)) ([db33cf3](https://github.com/NativeScript/NativeScript/commit/db33cf3)), closes [ac04ede#diff-f1459d509d1432b432c29bcd30e462fbL97](https://github.com/ac04ede/issues/diff-f1459d509d1432b432c29bcd30e462fbL97)
8+
* doc of transitionAndroid property of NavigationEntry interface ([#6563](https://github.com/NativeScript/NativeScript/issues/6563)) ([efe3318](https://github.com/NativeScript/NativeScript/commit/efe3318))
9+
* layoutChanged event in landscape ([#6520](https://github.com/NativeScript/NativeScript/issues/6520)) ([7fbdc7a](https://github.com/NativeScript/NativeScript/commit/7fbdc7a))
10+
* nested frames order with tabs & suspend/resume ([#6528](https://github.com/NativeScript/NativeScript/issues/6528)) ([7df8038](https://github.com/NativeScript/NativeScript/commit/7df8038))
11+
* Resolve incorrect name of listener when unsubscribing ([#6487](https://github.com/NativeScript/NativeScript/issues/6487)) ([af5eb73](https://github.com/NativeScript/NativeScript/commit/af5eb73))
12+
* Resolve incorrect name of listener when unsubscribing ([#6487](https://github.com/NativeScript/NativeScript/issues/6487)) ([2933a9a](https://github.com/NativeScript/NativeScript/commit/2933a9a))
13+
* **image:** uncaught error in promise with image handling ([#6453](https://github.com/NativeScript/NativeScript/issues/6453)) ([950fdcf](https://github.com/NativeScript/NativeScript/commit/950fdcf))
14+
* **android:** back navigation on app suspend/resume ([#6489](https://github.com/NativeScript/NativeScript/issues/6489)) ([999e378](https://github.com/NativeScript/NativeScript/commit/999e378))
15+
* **android:** back navigation on app suspend/resume ([#6489](https://github.com/NativeScript/NativeScript/issues/6489)) ([fac970e](https://github.com/NativeScript/NativeScript/commit/fac970e))
16+
* **android:** IllegalStateException with tabview&nested frames ([#6495](https://github.com/NativeScript/NativeScript/issues/6495)) ([7d21b5c](https://github.com/NativeScript/NativeScript/commit/7d21b5c))
17+
* **android:** IllegalStateException with tabview&nested frames ([#6495](https://github.com/NativeScript/NativeScript/issues/6495)) ([41ba93d](https://github.com/NativeScript/NativeScript/commit/41ba93d))
18+
* **ios:** safe area handling in scrollview ([#6561](https://github.com/NativeScript/NativeScript/issues/6561)) ([51a191f](https://github.com/NativeScript/NativeScript/commit/51a191f))
19+
* **ios:** scrollview safe area when no scroll ([#6568](https://github.com/NativeScript/NativeScript/issues/6568)) ([f90995f](https://github.com/NativeScript/NativeScript/commit/f90995f))
20+
21+
22+
### Features
23+
24+
* add number and phone input types for prompt dialog ([#6365](https://github.com/NativeScript/NativeScript/issues/6365)) ([7e7c050](https://github.com/NativeScript/NativeScript/commit/7e7c050))
25+
26+
327

428
<a name="5.0.2"></a>
529
## [5.0.2](https://github.com/NativeScript/NativeScript/compare/5.0.1...5.0.2) (2018-11-07)

‎apps/app/ui-tests-app/dialogs/dialogs.xml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
<Button text="login" tap="{{ loginName }}" />
88
<Button text="promptText" tap="{{ promptText }}" />
99
<Button text="promptPass" tap="{{ promptPass }}" />
10-
<Button text="promptEmail" tap="{{ promptEmail }}" />
10+
<Button text="promptEmail" tap="{{ promptEmail }}" />
11+
<Button text="promptNumber" tap="{{ promptNumber }}" />
12+
<Button text="promptPhone" tap="{{ promptPhone }}" />
1113
<Button text="promptCapitalizationNone" tap="{{ promptCapitalizationNone }}" />
1214
<Button text="promptCapitalizationAll" tap="{{ promptCapitalizationAll }}" />
1315
<Button text="promptCapitalizationSentences" tap="{{ promptCapitalizationSentences }}" />

‎apps/app/ui-tests-app/dialogs/view-model.ts‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,46 @@ export class SettingsViewModel extends observable.Observable {
138138
});
139139
}
140140

141+
public promptNumber(args: observable.EventData) {
142+
dialogs.prompt({
143+
title: "Name",
144+
message: "Enter a number:",
145+
cancelButtonText: "Cancel",
146+
neutralButtonText: "Ignore",
147+
okButtonText: "OK",
148+
defaultText: "1234",
149+
inputType: dialogs.inputType.number
150+
}).then((promptResult) => {
151+
console.log("### Result: " + promptResult.result + ", Text: " + promptResult.text);
152+
if (promptResult.result) {
153+
this.set("name", promptResult.text);
154+
}
155+
else {
156+
this.set("name", "1234");
157+
}
158+
});
159+
}
160+
161+
public promptPhone(args: observable.EventData) {
162+
dialogs.prompt({
163+
title: "Name",
164+
message: "Enter a phone:",
165+
cancelButtonText: "Cancel",
166+
neutralButtonText: "Ignore",
167+
okButtonText: "OK",
168+
defaultText: "1234",
169+
inputType: dialogs.inputType.phone
170+
}).then((promptResult) => {
171+
console.log("### Result: " + promptResult.result + ", Text: " + promptResult.text);
172+
if (promptResult.result) {
173+
this.set("name", promptResult.text);
174+
}
175+
else {
176+
this.set("name", "1234");
177+
}
178+
});
179+
}
180+
141181
public promptCapitalizationNone(args: observable.EventData) {
142182
dialogs.prompt({
143183
title: "Name",

‎apps/app/ui-tests-app/issues/issue-6439.css‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
.hr-light {
2+
height: 1;
3+
background-color: gray;
4+
}
5+
6+
.title {
7+
height: 200;
8+
}

‎apps/app/ui-tests-app/issues/issue-6439.xml‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
<Page>
2+
<ActionBar title="issue-6439"></ActionBar>
3+
4+
<GridLayout>
5+
<ScrollView>
6+
<StackLayout>
7+
<StackLayout>
8+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
9+
<StackLayout class="hr-light"></StackLayout>
10+
</StackLayout>
11+
<StackLayout>
12+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
13+
<StackLayout class="hr-light"></StackLayout>
14+
</StackLayout>
15+
<StackLayout>
16+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
17+
<StackLayout class="hr-light"></StackLayout>
18+
</StackLayout>
19+
<StackLayout>
20+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
21+
<StackLayout class="hr-light"></StackLayout>
22+
</StackLayout>
23+
<StackLayout>
24+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
25+
<StackLayout class="hr-light"></StackLayout>
26+
</StackLayout>
27+
<StackLayout>
28+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
29+
<StackLayout class="hr-light"></StackLayout>
30+
</StackLayout>
31+
<StackLayout>
32+
<Label text="Play with NativeScript!" textWrap="true" class="title" />
33+
<StackLayout class="hr-light"></StackLayout>
34+
</StackLayout>
35+
</StackLayout>
36+
</ScrollView>
37+
</GridLayout>
38+
</Page>

‎apps/app/ui-tests-app/issues/issue-ng-repo-1599.css‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
.page {
2+
padding: 20;
3+
}
4+
5+
.title {
6+
font-weight: bold;
7+
}
8+
9+
.list-items {
10+
border-radius: 10;
11+
background-repeat: no-repeat;
12+
background-size: cover;
13+
background-position: center top;
14+
background-color: black;
15+
margin-top: 20;
16+
}
17+
18+
.item-title {
19+
color: white;
20+
vertical-align: bottom;
21+
font-size: 30;
22+
padding: 180 20 20;
23+
font-weight: 600;
24+
}
25+
26+
.list-item__row {
27+
padding-left: 20;
28+
}
29+
30+
.list-item {
31+
border-radius: 4;
32+
background-color: white;
33+
margin: 0 10 20 0;
34+
padding: 5 10;
35+
}

‎apps/app/ui-tests-app/issues/issue-ng-repo-1599.xml‎

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
<Page>
2+
<ActionBar title="issue-ng-repo-1599"></ActionBar>
3+
4+
<ScrollView>
5+
<GridLayout rows="auto, *" columns="*" class="page page-content">
6+
<!-- Banner -->
7+
<StackLayout row="0" orientation="vertical">
8+
<StackLayout>
9+
<Label textWrap="true" text="My shopping lists" class="title"></Label>
10+
</StackLayout>
11+
</StackLayout>
12+
<!-- Offer categories -->
13+
<StackLayout row="1">
14+
<!-- Shopping list 1 -->
15+
<StackLayout class="list-items" backgroundImage="~/ui-tests-app/resources/images/woods.jpg">
16+
<Label text="Shopping list 1" class="item-title" textWrap="true"></Label>
17+
<ScrollView orientation="horizontal">
18+
<StackLayout orientation="horizontal" class="list-item__row">
19+
<StackLayout class="list-item">
20+
<Label text="Shop Item" textWrap="true" />
21+
</StackLayout>
22+
<StackLayout class="list-item">
23+
<Label text="Shop Item" textWrap="true" />
24+
</StackLayout>
25+
<StackLayout class="list-item">
26+
<Label text="Shop Item" textWrap="true" />
27+
</StackLayout>
28+
<StackLayout class="list-item">
29+
<Label text="Shop Item" textWrap="true" />
30+
</StackLayout>
31+
<StackLayout class="list-item">
32+
<Label text="Shop Item" textWrap="true" />
33+
</StackLayout>
34+
</StackLayout>
35+
</ScrollView>
36+
</StackLayout>
37+
<!-- Shopping list 2 -->
38+
<StackLayout class="list-items" backgroundImage="~/ui-tests-app/resources/images/woods.jpg">
39+
<Label text="Shopping list 2" class="item-title" textWrap="true"></Label>
40+
<ScrollView orientation="horizontal">
41+
<StackLayout orientation="horizontal" class="list-item__row">
42+
<StackLayout class="list-item">
43+
<Label text="Shop Item" textWrap="true" />
44+
</StackLayout>
45+
<StackLayout class="list-item">
46+
<Label text="Shop Item" textWrap="true" />
47+
</StackLayout>
48+
<StackLayout class="list-item">
49+
<Label text="Shop Item" textWrap="true" />
50+
</StackLayout>
51+
<StackLayout class="list-item">
52+
<Label text="Shop Item" textWrap="true" />
53+
</StackLayout>
54+
<StackLayout class="list-item">
55+
<Label text="Shop Item" textWrap="true" />
56+
</StackLayout>
57+
</StackLayout>
58+
</ScrollView>
59+
</StackLayout>
60+
<!-- Shopping list 3 -->
61+
<StackLayout class="list-items" backgroundImage="~/ui-tests-app/resources/images/woods.jpg">
62+
<Label text="Shopping list 3" class="item-title" textWrap="true"></Label>
63+
<ScrollView orientation="horizontal">
64+
<StackLayout orientation="horizontal" class="list-item__row">
65+
<StackLayout class="list-item">
66+
<Label text="Shop Item" textWrap="true" />
67+
</StackLayout>
68+
<StackLayout class="list-item">
69+
<Label text="Shop Item" textWrap="true" />
70+
</StackLayout>
71+
<StackLayout class="list-item">
72+
<Label text="Shop Item" textWrap="true" />
73+
</StackLayout>
74+
<StackLayout class="list-item">
75+
<Label text="Shop Item" textWrap="true" />
76+
</StackLayout>
77+
<StackLayout class="list-item">
78+
<Label text="Shop Item" textWrap="true" />
79+
</StackLayout>
80+
</StackLayout>
81+
</ScrollView>
82+
</StackLayout>
83+
<!-- Shopping list 4 -->
84+
<StackLayout class="list-items" backgroundImage="~/ui-tests-app/resources/images/woods.jpg">
85+
<Label text="Shopping list 4" class="item-title" textWrap="true"></Label>
86+
<ScrollView orientation="horizontal">
87+
<StackLayout orientation="horizontal" class="list-item__row">
88+
<StackLayout class="list-item">
89+
<Label text="Shop Item" textWrap="true" />
90+
</StackLayout>
91+
<StackLayout class="list-item">
92+
<Label text="Shop Item" textWrap="true" />
93+
</StackLayout>
94+
<StackLayout class="list-item">
95+
<Label text="Shop Item" textWrap="true" />
96+
</StackLayout>
97+
<StackLayout class="list-item">
98+
<Label text="Shop Item" textWrap="true" />
99+
</StackLayout>
100+
<StackLayout class="list-item">
101+
<Label text="Shop Item" textWrap="true" />
102+
</StackLayout>
103+
</StackLayout>
104+
</ScrollView>
105+
</StackLayout>
106+
</StackLayout>
107+
</GridLayout>
108+
</ScrollView>
109+
</Page>

‎apps/app/ui-tests-app/issues/main-page.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ export function loadExamples() {
2727
examples.set("3354-ios", "issues/issue-3354");
2828
examples.set("4450", "issues/issue-4450");
2929
examples.set("5274", "issues/issue-5274");
30+
examples.set("ng-repo-1599", "issues/issue-ng-repo-1599");
31+
examples.set("6439", "issues/issue-6439");
3032

3133
return examples;
3234
}

‎apps/app/ui-tests-app/scroll-view/safe-area-root-element.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</Page.actionBar>
77

88
<ScrollView>
9-
<StackLayout>
9+
<StackLayout backgroundColor="teal">
1010
<GridLayout height="30" backgroundColor="red" />
1111
<GridLayout height="30" backgroundColor="yellow" />
1212
<GridLayout height="30" backgroundColor="green" />

‎apps/app/ui-tests-app/scroll-view/safe-area-sub-element.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
</Page.actionBar>
77

88
<GridLayout>
9-
<ScrollView height="50" verticalAlignment="top">
10-
<StackLayout>
9+
<ScrollView>
10+
<StackLayout backgroundColor="teal">
1111
<GridLayout height="30" backgroundColor="red" />
1212
<GridLayout height="30" backgroundColor="yellow" />
1313
<GridLayout height="30" backgroundColor="green" />

0 commit comments

Comments
 (0)