fix(android): ignore gzip content-encoding for 204 statusCode (#7417)

lochstar · manoldonev · commit 4437cd622b4c · 2019-06-28T13:41:44.000+03:00
diff --git a/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/Async.java b/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/Async.java
@@ -409,8 +409,9 @@ public void readResponseStream(HttpURLConnection connection, Stack<Closeable> op
 
                 // In the event we don't have a null stream, and we have gzip as part of the encoding
                 // then we will use gzip to decode the stream
+                // Ignore gzip encoding for 204 'No Content' status to prevent java.io.EOFException
                 String encodingHeader = connection.getHeaderField("Content-Encoding");
-                if (encodingHeader != null && encodingHeader.toLowerCase().contains("gzip")) {
+                if (encodingHeader != null && encodingHeader.toLowerCase().contains("gzip") && this.statusCode != 204) {
                     inStream = new GZIPInputStream(inStream);
                 }
 
@@ -584,4 +585,4 @@ private void closeOpenedStreams(Stack<Closeable> streams) throws IOException {
             }
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -409,8 +409,9 @@ public void readResponseStream(HttpURLConnection connection, Stack<Closeable> op`
`409`	`409`
`410`	`410`	`// In the event we don't have a null stream, and we have gzip as part of the encoding`
`411`	`411`	`// then we will use gzip to decode the stream`
	`412`	`+ // Ignore gzip encoding for 204 'No Content' status to prevent java.io.EOFException`
`412`	`413`	`String encodingHeader = connection.getHeaderField("Content-Encoding");`
`413`		`- if (encodingHeader != null && encodingHeader.toLowerCase().contains("gzip")) {`
	`414`	`+ if (encodingHeader != null && encodingHeader.toLowerCase().contains("gzip") && this.statusCode != 204) {`
`414`	`415`	`inStream = new GZIPInputStream(inStream);`
`415`	`416`	`}`
`416`	`417`
`@@ -584,4 +585,4 @@ private void closeOpenedStreams(Stack<Closeable> streams) throws IOException {`
`584`	`585`	`}`
`585`	`586`	`}`
`586`	`587`	`}`
`587`		`-}`
	`588`	`+}`