Skip to content

Commit 30df4d9

Browse files
author
Alexander Vakrilov
authored
fix(modals): regression with modals in angular (#6655)
1 parent 0b239d7 commit 30df4d9

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

‎tns-core-modules/ui/core/view/view-common.ts‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -260,14 +260,13 @@ export abstract class ViewCommon extends ViewBase implements ViewDefinition {
260260
if (that._closeModalCallback) {
261261
const modalIndex = _rootModalViews.indexOf(that);
262262
_rootModalViews.splice(modalIndex);
263+
that._modalParent = null;
264+
that._modalContext = null;
265+
that._closeModalCallback = null;
266+
that._dialogClosed();
267+
parent._modal = null;
263268

264269
const whenClosedCallback = () => {
265-
that._modalParent = null;
266-
that._modalContext = null;
267-
that._closeModalCallback = null;
268-
that._dialogClosed();
269-
parent._modal = null;
270-
271270
if (typeof closeCallback === "function") {
272271
closeCallback.apply(undefined, originalArgs);
273272
}

0 commit comments

Comments
 (0)