fix(span): value handling for strings and numbers (#8651)

NathanWalker · web-flow · commit 0ca838ed0ced · 2020-06-17T11:07:38.000-07:00
closes #8647
diff --git a/nativescript-core/ui/text-base/span.ts b/nativescript-core/ui/text-base/span.ts
@@ -65,8 +65,9 @@ export class Span extends ViewBase implements SpanDefinition {
     }
     set text(value: string) {
         if (this._text !== value) {
-            this._text = value && value.replace("\\n", "\n").replace("\\t", "\t");
-            this.notifyPropertyChange("text", value);
+            // value can be a number
+            this._text = `${value}`.replace("\\n", "\n").replace("\\t", "\t");
+            this.notifyPropertyChange("text", this._text);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ export class Span extends ViewBase implements SpanDefinition {`
`65`	`65`	`}`
`66`	`66`	`set text(value: string) {`
`67`	`67`	`if (this._text !== value) {`
`68`		`- this._text = value && value.replace("\\n", "\n").replace("\\t", "\t");`
`69`		`- this.notifyPropertyChange("text", value);`
	`68`	`+ // value can be a number`
	`69`	+ this._text = `${value}`.replace("\\n", "\n").replace("\\t", "\t");
	`70`	`+ this.notifyPropertyChange("text", this._text);`
`70`	`71`	`}`
`71`	`72`	`}`
`72`	`73`