Fixes input order issue (laravel#14381)

amonger · taylorotwell · commit 6c553a7c1226 · 2016-07-20T08:09:24.000-05:00
diff --git a/src/Illuminate/Support/Collection.php b/src/Illuminate/Support/Collection.php
@@ -95,7 +95,7 @@ public function median($key = null)
         }
 
         $values = with(isset($key) ? $this->pluck($key) : $this)
-                    ->values()->sort();
+                    ->sort()->values();
 
         $middle = (int) floor($count / 2);
 
diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -1310,6 +1310,16 @@ public function testEvenMedianCollection()
         $this->assertEquals(1.5, $collection->median('foo'));
     }
 
+    public function testMedianOutOfOrderCollection()
+    {
+        $collection = new Collection([
+            (object) ['foo' => 0],
+            (object) ['foo' => 5],
+            (object) ['foo' => 3],
+        ]);
+        $this->assertEquals(3, $collection->median('foo'));
+    }
+
     public function testMedianOnEmptyCollectionReturnsNull()
     {
         $collection = new Collection();

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public function median($key = null)`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`$values = with(isset($key) ? $this->pluck($key) : $this)`
`98`		`- ->values()->sort();`
	`98`	`+ ->sort()->values();`
`99`	`99`
`100`	`100`	`$middle = (int) floor($count / 2);`
`101`	`101`