Skip to content

Commit ce1b13b

Browse files
committed
Fix failing ruleset tests.
@loveithateit: The ruleset check was not broken, but was finding a real problem with the ruleset: URLs like "http://marketing.yell.com///" don't get rewritten by the rule you were adding tests to, because they get caught by the exclusion. I've fixed the rule to only apply to the root URL, but please double check that this matches your intention.
1 parent 5316548 commit ce1b13b

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/chrome/content/rules/yell.com.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,13 @@
7777

7878
<!-- Redirects to http first:
7979
-->
80-
<rule from="^http://marketing\.yell\.com/+$"
80+
<rule from="^http://marketing\.yell\.com/$"
8181
to="https://business.yell.com/" />
8282

8383
<!-- There be faulty regex somewhere
8484
in the coverage checker...
8585
-->
86-
<test url="http://marketing.yell.com//" />
87-
<!--test url="http://marketing.yell.com///" /-->
88-
<!--test url="http://marketing.yell.com////" /-->
89-
<!--test url="http://marketing.yell.com/////" /-->
90-
<!--test url="http://marketing.yell.com//////" /-->
86+
<test url="http://marketing.yell.com/" />
9187

9288
<rule from="^http:"
9389
to="https:" />

0 commit comments

Comments
 (0)