Revert "fs: fix options.end of fs.ReadStream()"

MylesBorins · MylesBorins · commit d579aed960fb · 2018-03-13T15:41:35.000-04:00
This reverts commit df038ad. Some people were relying on the behavior of this.start being able to be undefined, whereas after the change it is being set to 0. Fixes: nodejs#19240 Refs: nodejs#18121
diff --git a/lib/fs.js b/lib/fs.js
@@ -1919,8 +1919,7 @@ function ReadStream(path, options) {
   this.flags = options.flags === undefined ? 'r' : options.flags;
   this.mode = options.mode === undefined ? 0o666 : options.mode;
 
-  this.start = typeof this.fd !== 'number' && options.start === undefined ?
-    0 : options.start;
+  this.start = options.start;
   this.end = options.end;
   this.autoClose = options.autoClose === undefined ? true : options.autoClose;
   this.pos = undefined;
diff --git a/test/parallel/test-fs-read-stream.js b/test/parallel/test-fs-read-stream.js
@@ -132,20 +132,6 @@ stream.on('end', function() {
   assert.strictEqual('x', stream.data);
 });
 
-{
-  // Verify that end works when start is not specified.
-  const stream = new fs.createReadStream(rangeFile, { end: 1 });
-  stream.data = '';
-
-  stream.on('data', function(chunk) {
-    stream.data += chunk;
-  });
-
-  stream.on('end', common.mustCall(function() {
-    assert.strictEqual('xy', stream.data);
-  }));
-}
-
 // pause and then resume immediately.
 const pauseRes = fs.createReadStream(rangeFile);
 pauseRes.pause();
