Consider JsonGenerator.Feature#AUTO_CLOSE_TARGET

komamitsu · komamitsu · commit dad4a73142db · 2015-05-25T23:51:35.000+09:00
diff --git a/msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java b/msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java
@@ -330,8 +330,10 @@ public void close() throws IOException {
             flush();
         }
         finally {
-            MessagePacker messagePacker = getMessagePacker();
-            messagePacker.close();
+            if (isEnabled(Feature.AUTO_CLOSE_TARGET)) {
+                MessagePacker messagePacker = getMessagePacker();
+                messagePacker.close();
+            }
         }
     }
 
diff --git a/msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackGeneratorTest.java b/msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackGeneratorTest.java
@@ -25,6 +25,7 @@
 
 import java.io.File;
 import java.io.FileInputStream;
+import java.io.FileOutputStream;
 import java.io.IOException;
 import java.math.BigDecimal;
 import java.util.*;
@@ -263,4 +264,17 @@ public void testBigDecimal() throws IOException {
             }
         }
     }
+
+    @Test
+    public void testDisableFeatureAutoCloseTarget() throws IOException {
+        File tempFile = File.createTempFile("test", "msgpack");
+        FileOutputStream out = new FileOutputStream(tempFile);
+        MessagePackFactory messagePackFactory = new MessagePackFactory();
+        messagePackFactory.disable(JsonGenerator.Feature.AUTO_CLOSE_TARGET);
+        ObjectMapper objectMapper = new ObjectMapper(messagePackFactory);
+        List<Integer> integers = Arrays.asList(1);
+        objectMapper.writeValue(out, integers);
+        objectMapper.writeValue(out, integers);
+        out.close();
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -330,8 +330,10 @@ public void close() throws IOException {`
`330`	`330`	`flush();`
`331`	`331`	`}`
`332`	`332`	`finally {`
`333`		`- MessagePacker messagePacker = getMessagePacker();`
`334`		`- messagePacker.close();`
	`333`	`+ if (isEnabled(Feature.AUTO_CLOSE_TARGET)) {`
	`334`	`+ MessagePacker messagePacker = getMessagePacker();`
	`335`	`+ messagePacker.close();`
	`336`	`+ }`
`335`	`337`	`}`
`336`	`338`	`}`
`337`	`339`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`
`26`	`26`	`import java.io.File;`
`27`	`27`	`import java.io.FileInputStream;`
	`28`	`+import java.io.FileOutputStream;`
`28`	`29`	`import java.io.IOException;`
`29`	`30`	`import java.math.BigDecimal;`
`30`	`31`	`import java.util.*;`
`@@ -263,4 +264,17 @@ public void testBigDecimal() throws IOException {`
`263`	`264`	`}`
`264`	`265`	`}`
`265`	`266`	`}`
	`267`	`+`
	`268`	`+ @Test`
	`269`	`+ public void testDisableFeatureAutoCloseTarget() throws IOException {`
	`270`	`+ File tempFile = File.createTempFile("test", "msgpack");`
	`271`	`+ FileOutputStream out = new FileOutputStream(tempFile);`
	`272`	`+ MessagePackFactory messagePackFactory = new MessagePackFactory();`
	`273`	`+ messagePackFactory.disable(JsonGenerator.Feature.AUTO_CLOSE_TARGET);`
	`274`	`+ ObjectMapper objectMapper = new ObjectMapper(messagePackFactory);`
	`275`	`+ List<Integer> integers = Arrays.asList(1);`
	`276`	`+ objectMapper.writeValue(out, integers);`
	`277`	`+ objectMapper.writeValue(out, integers);`
	`278`	`+ out.close();`
	`279`	`+ }`
`266`	`280`	`}`