Fix Console Errors (refined-github#1359)

busches · fregante · commit 1d1f228bdab9 · 2018-06-04T20:49:56.000+02:00
* Fix console error when clicking on More (Next to releases)

* Fix console error when on Gist page

* Fix console error when on Gist profile page
diff --git a/source/content.js b/source/content.js
@@ -109,7 +109,7 @@ async function init() {
 		enableFeature(addTrendingMenuItem);
 	}
 
-	if (pageDetect.isDashboard()) {
+	if (pageDetect.isDashboard() && !pageDetect.isGist()) {
 		enableFeature(hideUselessNewsfeedEvents);
 	}
 
diff --git a/source/features/close-out-of-view-modals.js b/source/features/close-out-of-view-modals.js
@@ -17,11 +17,12 @@ const observer = new IntersectionObserver(([{intersectionRatio, target}]) => {
 export default function () {
 	delegate('.dropdown-details, .js-menu-target', 'click', event => {
 		const button = event.delegateTarget;
-		const modal = button
-			.closest('.select-menu, .dropdown, details')
-			.querySelector('.select-menu-modal, .dropdown-menu');
-		if (modal && (!button.open || button.classList.contains('selected'))) {
-			observer.observe(modal);
+		const menu = button.closest('.select-menu, .dropdown, details');
+		if (menu) {
+			const modal = menu.querySelector('.select-menu-modal, .dropdown-menu');
+			if (modal && (!button.open || button.classList.contains('selected'))) {
+				observer.observe(modal);
+			}
 		}
 	});
 }
diff --git a/source/features/copy-file.js b/source/features/copy-file.js
@@ -15,11 +15,13 @@ export default function () {
 
 		// Prepend to list of buttons
 		const firstAction = select('.file-actions .btn', file);
-		firstAction.before(
-			<button onClick={handleClick} class="btn btn-sm copy-btn tooltipped tooltipped-n" aria-label="Copy file to clipboard" type="button">Copy</button>
-		);
+		if (firstAction) {
+			firstAction.before(
+				<button onClick={handleClick} class="btn btn-sm copy-btn tooltipped tooltipped-n" aria-label="Copy file to clipboard" type="button">Copy</button>
+			);
 
-		// Group buttons if necessary
-		groupSiblings(firstAction);
+			// Group buttons if necessary
+			groupSiblings(firstAction);
+		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ async function init() {`
`109`	`109`	`enableFeature(addTrendingMenuItem);`
`110`	`110`	`}`
`111`	`111`
`112`		`- if (pageDetect.isDashboard()) {`
	`112`	`+ if (pageDetect.isDashboard() && !pageDetect.isGist()) {`
`113`	`113`	`enableFeature(hideUselessNewsfeedEvents);`
`114`	`114`	`}`
`115`	`115`