Rename to_table to to_arrow (feast-dev#1671)

MattDelac · Mwad22 · commit d0fe0a9a9849 · 2021-07-07T17:33:17.000-04:00
Signed-off-by: Matt Delacour &lt;matt.delacour@shopify.com&gt;
Signed-off-by: Mwad22 &lt;51929507+Mwad22@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/infra/gcp.py b/sdk/python/feast/infra/gcp.py
@@ -110,7 +110,7 @@ def materialize_single_feature_view(
             start_date=start_date,
             end_date=end_date,
         )
-        table = offline_job.to_table()
+        table = offline_job.to_arrow()
 
         if feature_view.input.field_mapping is not None:
             table = _run_field_mapping(table, feature_view.input.field_mapping)
diff --git a/sdk/python/feast/infra/local.py b/sdk/python/feast/infra/local.py
@@ -109,7 +109,7 @@ def materialize_single_feature_view(
             end_date=end_date,
             config=config,
         )
-        table = offline_job.to_table()
+        table = offline_job.to_arrow()
 
         if feature_view.input.field_mapping is not None:
             table = _run_field_mapping(table, feature_view.input.field_mapping)
diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -277,7 +277,7 @@ def _block_until_done():
         print(f"Done writing to '{job_config.destination}'.")
         return str(job_config.destination)
 
-    def to_table(self) -> pyarrow.Table:
+    def to_arrow(self) -> pyarrow.Table:
         return self.client.query(self.query).to_arrow()
 
 
diff --git a/sdk/python/feast/infra/offline_stores/file.py b/sdk/python/feast/infra/offline_stores/file.py
@@ -38,7 +38,7 @@ def to_df(self):
         df = self.evaluation_function()
         return df
 
-    def to_table(self):
+    def to_arrow(self):
         # Only execute the evaluation function to build the final historical retrieval dataframe at the last moment.
         df = self.evaluation_function()
         return pyarrow.Table.from_pandas(df)
diff --git a/sdk/python/feast/infra/offline_stores/offline_store.py b/sdk/python/feast/infra/offline_stores/offline_store.py
@@ -33,7 +33,7 @@ def to_df(self) -> pd.DataFrame:
         pass
 
     @abstractmethod
-    def to_table(self) -> pyarrow.Table:
+    def to_arrow(self) -> pyarrow.Table:
         """Return dataset as pyarrow Table synchronously"""
         pass
 
diff --git a/sdk/python/tensorflow_metadata/proto/v0/path_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/path_pb2.py
diff --git a/sdk/python/tensorflow_metadata/proto/v0/schema_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/schema_pb2.py
diff --git a/sdk/python/tensorflow_metadata/proto/v0/statistics_pb2.py b/sdk/python/tensorflow_metadata/proto/v0/statistics_pb2.py
diff --git a/sdk/python/tests/test_historical_retrieval.py b/sdk/python/tests/test_historical_retrieval.py
@@ -508,7 +508,7 @@ def test_historical_features_from_bigquery_sources(
             check_dtype=False,
         )
 
-        table_from_sql_entities = job_from_sql.to_table()
+        table_from_sql_entities = job_from_sql.to_arrow()
         assert_frame_equal(
             actual_df_from_sql_entities, table_from_sql_entities.to_pandas()
         )
@@ -594,8 +594,7 @@ def test_historical_features_from_bigquery_sources(
             .reset_index(drop=True),
             check_dtype=False,
         )
-
-        table_from_df_entities = job_from_df.to_table()
+        table_from_df_entities = job_from_df.to_arrow()
         assert_frame_equal(
             actual_df_from_df_entities, table_from_df_entities.to_pandas()
         )

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ def materialize_single_feature_view(`
`110`	`110`	`start_date=start_date,`
`111`	`111`	`end_date=end_date,`
`112`	`112`	`)`
`113`		`- table = offline_job.to_table()`
	`113`	`+ table = offline_job.to_arrow()`
`114`	`114`
`115`	`115`	`if feature_view.input.field_mapping is not None:`
`116`	`116`	`table = _run_field_mapping(table, feature_view.input.field_mapping)`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ def materialize_single_feature_view(`
`109`	`109`	`end_date=end_date,`
`110`	`110`	`config=config,`
`111`	`111`	`)`
`112`		`- table = offline_job.to_table()`
	`112`	`+ table = offline_job.to_arrow()`
`113`	`113`
`114`	`114`	`if feature_view.input.field_mapping is not None:`
`115`	`115`	`table = _run_field_mapping(table, feature_view.input.field_mapping)`
Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ def test_historical_features_from_bigquery_sources(`
`508`	`508`	`check_dtype=False,`
`509`	`509`	`)`
`510`	`510`
`511`		`- table_from_sql_entities = job_from_sql.to_table()`
	`511`	`+ table_from_sql_entities = job_from_sql.to_arrow()`
`512`	`512`	`assert_frame_equal(`
`513`	`513`	`actual_df_from_sql_entities, table_from_sql_entities.to_pandas()`
`514`	`514`	`)`
`@@ -594,8 +594,7 @@ def test_historical_features_from_bigquery_sources(`
`594`	`594`	`.reset_index(drop=True),`
`595`	`595`	`check_dtype=False,`
`596`	`596`	`)`
`597`		`-`
`598`		`- table_from_df_entities = job_from_df.to_table()`
	`597`	`+ table_from_df_entities = job_from_df.to_arrow()`
`599`	`598`	`assert_frame_equal(`
`600`	`599`	`actual_df_from_df_entities, table_from_df_entities.to_pandas()`
`601`	`600`	`)`