Skip to content

Commit 4840a39

Browse files
committed
Lint fixes
1 parent b55defd commit 4840a39

12 files changed

Lines changed: 12 additions & 21 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ Recommended Software:
2727
You are free to choose your development environment regarding text editors or
2828
additional tools, however I recommend using either [Atom](https://atom.io/) or [Visual Studio Code](https://code.visualstudio.com/).
2929

30-
3130
## Getting Ready
3231

3332
Ok, so you've installed everything you need to start contributing to Monogatari,
@@ -79,7 +78,7 @@ yarn run build:core
7978
your changes.
8079

8180
```bash
82-
git commit <List of files to commit> -m "A message describing what you did in present tense"
81+
git commit <List of files to commit> -m "A message describing what you did in present tense, should start with a capital letter."
8382
```
8483

8584
8) Push the modified code to your Fork

dist/engine/electron/preload.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* global require */
12
const { ipcRenderer } = require ('electron');
23

34
window.ipcRendererSend = function (...args) {

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,12 @@
2121
"build:js": "yarn parcel build ./src/index.js --global Monogatari --out-file monogatari.js --out-dir dist/engine/core --no-cache --public-url .",
2222
"build:debug": "yarn parcel build ./debug/index.js --global MonogatariDebug --out-file debug.js --out-dir dist/engine/debug --no-cache --public-url .",
2323
"build:css": "yarn parcel build ./src/index.css --out-file monogatari.css --out-dir dist/engine/core --no-cache --no-source-maps",
24-
"eslint": "yarn eslint ./src/index.js ./src/actions/* ./src/translations/*",
2524
"watch:js": "yarn parcel watch ./src/index.js --global Monogatari --out-file monogatari.js --out-dir dist/engine/core --no-cache --public-url .",
26-
"watch:css": "yarn parcel watch ./src/index.css --out-file monogatari.css --out-dir dist/engine/core --no-cache --no-source-maps"
25+
"watch:css": "yarn parcel watch ./src/index.css --out-file monogatari.css --out-dir dist/engine/core --no-cache --no-source-maps",
26+
"lint:html": "yarn htmlhint ./dist/index.html",
27+
"lint:js": "yarn eslint ./src --ext .js --ignore-pattern *.min.js && yarn eslint ./dist/js --ext .js --ignore-pattern *.min.js && yarn eslint ./dist/engine/electron --ext .js && yarn eslint ./dist/service-worker.js",
28+
"lint:css": "yarn stylelint ./src/**/*.css ./dist/style/**/*.css --ignore-pattern *.min.css",
29+
"lint": "yarn lint:html && yarn lint:js && yarn lint:css"
2730
},
2831
"devDependencies": {
2932
"@babel/core": "^7.6.4",

src/actions/Choice.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Action } from './../lib/Action';
1+
import { Action } from '../lib/Action';
22
import { Util } from '@aegis-framework/artemis';
33

44
export class Choice extends Action {
@@ -104,7 +104,7 @@ export class Choice extends Action {
104104
this.engine.assertAsync (this.statement[i].Condition, this.engine).then (() => {
105105
resolve (this.statement[i]);
106106
}).catch (() => {
107-
resolve()
107+
resolve ();
108108
}).finally (() => {
109109
//this.engine.global ('block', false);
110110
});

src/actions/Particles.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Action } from './../lib/Action';
1+
import { Action } from '../lib/Action';
22

33
/* global particlesJS, pJSDom */
44

@@ -48,7 +48,7 @@ export class Particles extends Action {
4848
static onLoad () {
4949
const { particles } = this.engine.state ();
5050
if (particles !== '') {
51-
const promise = this.engine.run (particles, false);
51+
const promise = this.engine.run (particles, false);
5252
// TODO: Find a way to prevent the histories from filling up on loading
5353
// So there's no need for this pop.
5454
this.engine.history ('particle').pop ();

src/style/monogatari.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,7 @@ button {
8383
background-size: contain;
8484
background-repeat: no-repeat;
8585
background-position: center;
86-
}
8786

88-
button {
8987
&:hover,
9088
&:focus {
9189
background-color: var(--main-color);

src/translations/Deutsch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* KazutoSensei
1010
*/
1111

12-
export default {
12+
export default {
1313
'AdvanceHelp': 'Um dich durch das Spiel zu navigieren, drücke die Leertaste oder klicke',
1414
'AllowPlayback': 'Click here to allow audio playback',
1515
'Audio': 'Audio',

src/translations/Español.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
* Hyuchia <diego@hyuchia.com>
99
*/
1010

11-
import { Monogatari } from './../monogatari';
12-
1311
export default {
1412
'AdvanceHelp': 'Para avanzar en el juego, presiona espacio o haz click',
1513
'AllowPlayback': 'Click here to allow audio playback',

src/translations/Français.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
* BakaKiller
99
*/
1010

11-
import { Monogatari } from './../monogatari';
12-
1311
export default {
1412
'AdvanceHelp': 'Pour avancer dans le jeu, appuyez sur la touche espace ou cliquez',
1513
'AllowPlayback': 'Click here to allow audio playback',

src/translations/Nederlands.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
* Natsukeep
99
*/
1010

11-
import { Monogatari } from './../monogatari';
12-
1311
export default {
1412
'AdvanceHelp': 'Gebruik de spatiebalk of linker muisknop om te spelen',
1513
'AllowPlayback': 'Click here to allow audio playback',

0 commit comments

Comments
 (0)