Skip to content

Commit 68311de

Browse files
mfeurerPGijsbers
authored andcommitted
Speed up dataset unit tests (openml#1056)
* Speed up dataset unit tests by only loading necessary datasets * Revert "Speed up dataset unit tests" This reverts commit 861b52d. * address suggestions from Pieter
1 parent 22b7c58 commit 68311de

1 file changed

Lines changed: 35 additions & 5 deletions

File tree

tests/test_datasets/test_dataset.py

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,43 @@ def setUp(self):
2424

2525
# Load dataset id 2 - dataset 2 is interesting because it contains
2626
# missing values, categorical features etc.
27-
self.dataset = openml.datasets.get_dataset(2, download_data=False)
27+
self._dataset = None
2828
# titanic as missing values, categories, and string
29-
self.titanic = openml.datasets.get_dataset(40945, download_data=False)
29+
self._titanic = None
3030
# these datasets have some boolean features
31-
self.pc4 = openml.datasets.get_dataset(1049, download_data=False)
32-
self.jm1 = openml.datasets.get_dataset(1053, download_data=False)
33-
self.iris = openml.datasets.get_dataset(61, download_data=False)
31+
self._pc4 = None
32+
self._jm1 = None
33+
self._iris = None
34+
35+
@property
36+
def dataset(self):
37+
if self._dataset is None:
38+
self._dataset = openml.datasets.get_dataset(2, download_data=False)
39+
return self._dataset
40+
41+
@property
42+
def titanic(self):
43+
if self._titanic is None:
44+
self._titanic = openml.datasets.get_dataset(40945, download_data=False)
45+
return self._titanic
46+
47+
@property
48+
def pc4(self):
49+
if self._pc4 is None:
50+
self._pc4 = openml.datasets.get_dataset(1049, download_data=False)
51+
return self._pc4
52+
53+
@property
54+
def jm1(self):
55+
if self._jm1 is None:
56+
self._jm1 = openml.datasets.get_dataset(1053, download_data=False)
57+
return self._jm1
58+
59+
@property
60+
def iris(self):
61+
if self._iris is None:
62+
self._iris = openml.datasets.get_dataset(61, download_data=False)
63+
return self._iris
3464

3565
def test_repr(self):
3666
# create a bare-bones dataset as would be returned by

0 commit comments

Comments
 (0)