From f9a167492266683ab10b7112ad184b9f931796ce Mon Sep 17 00:00:00 2001 From: TylerMSFT Date: Tue, 18 May 2021 13:49:49 -0700 Subject: [PATCH 1/5] tech review --- docs/build/walkthrough-header-units.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/build/walkthrough-header-units.md b/docs/build/walkthrough-header-units.md index ed5ede8ebe9..60c89b7d790 100644 --- a/docs/build/walkthrough-header-units.md +++ b/docs/build/walkthrough-header-units.md @@ -66,7 +66,7 @@ In this example, you'll compile a header file as a header unit. Start by creatin #include - void PrintPythagoreanTriple(int a, int b) + inline void PrintPythagoreanTriple(int a, int b) { std::cout << "Pythagorean triple a:" << a << " b:" << b << " c:" << a*a + b*b << std::endl; } From 38939f1480f94c616e05cb72b2d5026ea77b5652 Mon Sep 17 00:00:00 2001 From: TylerMSFT Date: Tue, 18 May 2021 13:56:04 -0700 Subject: [PATCH 2/5] tech review --- docs/build/reference/module-exportheader.md | 6 +++--- docs/build/walkthrough-header-units.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/build/reference/module-exportheader.md b/docs/build/reference/module-exportheader.md index 0bd2fbcf063..5ba5ef02b8d 100644 --- a/docs/build/reference/module-exportheader.md +++ b/docs/build/reference/module-exportheader.md @@ -1,7 +1,7 @@ --- title: "/exportHeader (Create header units)" description: "Use the /exportHeader compiler option to create module header units for the header-name or include files specified." -ms.date: 04/13/2020 +ms.date: 05/18/2020 author: "tylermsft" ms.author: "twhitney" f1_keywords: ["/exportHeader"] @@ -13,8 +13,8 @@ Tells the compiler to create the header units specified by the input arguments. ## Syntax -> **`/exportHeader /headerName:angle`** *`header-name`* -> **`/exportHeader /headerName:quote`** *`header-name`* +> **`/exportHeader /headerName:angle`** *`header-name`*\ +> **`/exportHeader /headerName:quote`** *`header-name`*\ > **`/exportHeader`** *`full path to header file`* ### Arguments diff --git a/docs/build/walkthrough-header-units.md b/docs/build/walkthrough-header-units.md index 60c89b7d790..18166707c77 100644 --- a/docs/build/walkthrough-header-units.md +++ b/docs/build/walkthrough-header-units.md @@ -1,7 +1,7 @@ --- description: "Learn more about C++ header units by converting a header file to a header unit by using Visual Studio 2019." title: "Walkthrough: Build and import header units in Visual C++ projects" -ms.date: "4/13/2021" +ms.date: "5/18/2021" ms.custom: "conceptual" author: "tylermsft" ms.author: "twhitney" From fdf62d0fc64f5069177c2c3bc8e4acd9024c6045 Mon Sep 17 00:00:00 2001 From: TylerMSFT Date: Tue, 18 May 2021 14:13:01 -0700 Subject: [PATCH 3/5] fix see also --- docs/build/walkthrough-header-units.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/build/walkthrough-header-units.md b/docs/build/walkthrough-header-units.md index 18166707c77..cb409bb5c8f 100644 --- a/docs/build/walkthrough-header-units.md +++ b/docs/build/walkthrough-header-units.md @@ -109,5 +109,5 @@ If you want to convert only a few header files to header units, this approach is [Walkthrough: Import STL libraries as header units](walkthrough-import-stl-header-units.md#approach1)\ [Overview of modules in C++](../cpp/modules-cpp.md) \ [`/translateInclude`](./reference/translateinclude.md) \ -[`/exportHeader`](./reference/module-exportheader.md) \ +[`/headerName`](./reference/headername.md) \ [`/headerUnit`](./reference/headerunit.md) \ No newline at end of file From e27f15a513c35369f4de3c86c3c0979566f0604e Mon Sep 17 00:00:00 2001 From: TylerMSFT Date: Tue, 18 May 2021 14:21:43 -0700 Subject: [PATCH 4/5] fix see also --- docs/build/reference/module-exportheader.md | 1 + docs/build/walkthrough-header-units.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/build/reference/module-exportheader.md b/docs/build/reference/module-exportheader.md index 5ba5ef02b8d..cdd9f8dae0a 100644 --- a/docs/build/reference/module-exportheader.md +++ b/docs/build/reference/module-exportheader.md @@ -57,6 +57,7 @@ You normally shouldn't set this in the Visual Studio development environment. It ## See also +[`/headerName (Build a header unit from the specified header)`](./reference/headername.md) \ [`/headerUnit` (Use header unit IFC)](headerunit.md)\ [`/reference` (Use named module IFC)](module-reference.md)\ [`/translateInclude` (Translate include directives into import directives)](translateinclude.md) diff --git a/docs/build/walkthrough-header-units.md b/docs/build/walkthrough-header-units.md index cb409bb5c8f..18166707c77 100644 --- a/docs/build/walkthrough-header-units.md +++ b/docs/build/walkthrough-header-units.md @@ -109,5 +109,5 @@ If you want to convert only a few header files to header units, this approach is [Walkthrough: Import STL libraries as header units](walkthrough-import-stl-header-units.md#approach1)\ [Overview of modules in C++](../cpp/modules-cpp.md) \ [`/translateInclude`](./reference/translateinclude.md) \ -[`/headerName`](./reference/headername.md) \ +[`/exportHeader`](./reference/module-exportheader.md) \ [`/headerUnit`](./reference/headerunit.md) \ No newline at end of file From 28fc5f9c96c0691001d81390aa8222d19530988f Mon Sep 17 00:00:00 2001 From: TylerMSFT Date: Tue, 18 May 2021 14:27:53 -0700 Subject: [PATCH 5/5] fix link --- docs/build/reference/module-exportheader.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/build/reference/module-exportheader.md b/docs/build/reference/module-exportheader.md index cdd9f8dae0a..bf2899dee72 100644 --- a/docs/build/reference/module-exportheader.md +++ b/docs/build/reference/module-exportheader.md @@ -57,7 +57,7 @@ You normally shouldn't set this in the Visual Studio development environment. It ## See also -[`/headerName (Build a header unit from the specified header)`](./reference/headername.md) \ +[`/headerName (Build a header unit from the specified header)`](headername.md) \ [`/headerUnit` (Use header unit IFC)](headerunit.md)\ [`/reference` (Use named module IFC)](module-reference.md)\ [`/translateInclude` (Translate include directives into import directives)](translateinclude.md)