Change algorithm for searching for Jupyter#3433
Merged
Merged
Conversation
Author
|
This is an early review so Ian can get a look. #Resolved |
DonJayamanne
requested changes
Nov 22, 2018
DonJayamanne
left a comment
There was a problem hiding this comment.
The PR seems to indicate we're merely changing an algorithm, but we're changing a significant amount of code (unrelated).
DonJayamanne
requested changes
Nov 26, 2018
DonJayamanne
requested changes
Nov 26, 2018
DonJayamanne
requested changes
Nov 26, 2018
Author
|
@DonJayamanne and @IanMatthewHuff this should be ready to look at again if you can. Thanks. |
DonJayamanne
requested changes
Nov 27, 2018
DonJayamanne
approved these changes
Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify how we find jupyter. If the current python environment doesn't allow jupyter to run, look for one that does and then use the current environment to create a kernelspec that points to the current environment.
Also output the jupyter version into the sysinfo
For #3341, #3335
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)