🔥 remove jupyter commands#1034
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 64.07% 64.04% -0.03%
==========================================
Files 260 260
Lines 12013 12010 -3
Branches 2134 2133 -1
==========================================
- Hits 7697 7692 -5
- Misses 4307 4309 +2
Partials 9 9
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
Mar 12, 2018
DonJayamanne
left a comment
There was a problem hiding this comment.
@neilsustc
- Remove the
jupytercommands from the localization files as well (package.nls.*.json). - Remove
jupyterDecrationInfofromsrc/client/common/featureDeprecationManager.ts
Author
|
Done. And it seems that |
|
@neilsustc |
DonJayamanne
approved these changes
Mar 12, 2018
Member
|
@DonJayamanne can you add a news entry for this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #897.