Draft
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-previews |
bergarces
commented
Apr 15, 2026
| | { | ||
| accountType: EvmAccountType; | ||
| assetId: Hex; // This is also the address for EVM tokens | ||
| assetId: CaipAssetType; |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change result from the bad decision in BIP44 days of setting assetId as the address for evm assets, which is very confusing and means we have no access to the assetId at all.
This is the main change of this PR.
bergarces
commented
Apr 15, 2026
| chainId: `${string}:${string}`; | ||
| assetId: CaipAssetType; | ||
| address: CaipAssetType; | ||
| chainId: CaipChainId; |
Contributor
Author
There was a problem hiding this comment.
No breaking changes here, just using the correct type.
Added address here too, because otherwise the type is annoying to handle (it won't let you access asset.address as it doesn't always exist. The PRs implementing this breaking change show how this can simplify the code.
bergarces
commented
Apr 15, 2026
| hexToNumber(chainId).toString(), | ||
| 'erc20', | ||
| ZERO_ADDRESS, | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
We need a default here, and erc20:0x0000...0000 is a better default than slip44:60, as it usually works even when there is a slip44 entry and it doesn't assume it's ETH. It does assume that the native token is the zero address, but there is only a handful of chains for which that is not the case, and we hopefully have the captured in the settings.
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
assetIdis being populated with the evm address for evm assets, which is both confusing and makes it cumbersome to extract the realassetIdin the clients.References
Checklist