Merge pull request #7 from Kushmanmb/copilot/refactor-duplicated-code

Kushmanmb · web-flow · commit 6cc87991d0da · 2026-01-24T20:47:32.000-05:00
Extract duplicated Node.js setup logic into reusable composite action
diff --git a/actions/setup-node-from-nvmrc/README.md b/actions/setup-node-from-nvmrc/README.md
@@ -0,0 +1,28 @@
+# Setup Node.js from .nvmrc
+
+A reusable composite action that sets up Node.js using the version specified in an `.nvmrc` file.
+
+## Usage
+
+```yaml
+steps:
+  - uses: actions/checkout@v2
+  - name: Setup Node.js from .nvmrc
+    uses: ./actions/setup-node-from-nvmrc
+```
+
+## Requirements
+
+- The repository must have an `.nvmrc` file in the root directory
+- The `.nvmrc` file should contain a valid Node.js version (e.g., `16.14.0`, `18.x`)
+
+## What it does
+
+1. Reads the Node.js version from the `.nvmrc` file
+2. Sets up Node.js with the specified version using `actions/setup-node@v2`
+
+## Benefits
+
+- Centralizes Node.js version management in `.nvmrc`
+- Eliminates duplicated setup code across workflows
+- Uses modern GitHub Actions output syntax (`$GITHUB_OUTPUT`)
diff --git a/actions/setup-node-from-nvmrc/action.yml b/actions/setup-node-from-nvmrc/action.yml
@@ -0,0 +1,13 @@
+name: 'Setup Node.js from .nvmrc'
+description: 'Sets up Node.js using the version specified in .nvmrc file'
+runs:
+  using: "composite"
+  steps:
+    - name: Get Node.js version
+      id: nvm
+      shell: bash
+      run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_OUTPUT
+    - name: Setup Node.js
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
diff --git a/workflow-templates/build-lint-test.yml b/workflow-templates/build-lint-test.yml
@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
       - run: yarn --frozen-lockfile --ignore-scripts
diff --git a/workflow-templates/create-release-pr.yml b/workflow-templates/create-release-pr.yml
@@ -29,12 +29,8 @@ jobs:
           # We check out the specified branch, which will be used as the base
           # branch for all git operations and the release PR.
           ref: ${{ github.event.inputs.base-branch }}
-      - name: Get Node.js version
-        id: nvm
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
-      - uses: actions/setup-node@v2
-        with:
-          node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
+      - name: Setup Node.js from .nvmrc
+        uses: ./actions/setup-node-from-nvmrc
       - uses: MetaMask/action-create-release-pr@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/workflow-templates/publish-release.yml b/workflow-templates/publish-release.yml
@@ -14,12 +14,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: Get Node.js version
-        id: nvm
-        run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
-      - uses: actions/setup-node@v2
-        with:
-          node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
+      - name: Setup Node.js from .nvmrc
+        uses: ./actions/setup-node-from-nvmrc
       - uses: MetaMask/action-publish-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
