Skip to content

Remove explicit header and footer restriction #599

Closed
Closed
Remove explicit header and footer restriction#599
Labels
enhancement
Milestone
1.0

Description

@SD10
SD10
opened on Mar 28, 2018

The current API is actually restricting because we have an explicit MessageHeaderView and MessageFooterView. After #596 is merged we will have a MessageReusableView class. I'm going to suggest we just remove the explicit header / footer classes in favor of using the reusable view.

I'm just not sure whether to put this in 1.0 or not. It's just adding to the pile of changes. Maybe better fit for next major version as its not extremely important.

Activity

  1. SD10
    added
    enhancement
    on Mar 28, 2018
  2. SD10
    added this to the 2.0 milestone on Mar 28, 2018

  3. hyouuu commented on Mar 29, 2018

    @hyouuu
    hyouuu
    on Mar 29, 2018
    Contributor

    I'd vote for 1.0 ;)

  4. SD10 commented on Mar 30, 2018

    @SD10
    SD10
    on Mar 30, 2018
    MemberAuthor

    We can’t put many more changes in 1.0, it has enough 😥. The responsible thing to do is leave this out

    Sent with GitHawk

  5. hyouuu commented on Mar 30, 2018

    @hyouuu
    hyouuu
    on Mar 30, 2018
    Contributor

    Understood!

  6. SD10 commented on Mar 30, 2018

    @SD10
    SD10
    on Mar 30, 2018
    MemberAuthor

    We're required to put this in 1.0 now due to other reasons

  7. SD10
    modified the milestones: 2.0, 1.0 on Mar 30, 2018
  8. SD10
    closed this as completedon Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions