Skip to content

Cell top label needs more vertical space or ability to set dynamically  #161

Closed
Closed
Cell top label needs more vertical space or ability to set dynamically #161
Assignees
SD10
Labels
enhancement
Milestone
0.9.0

Description

@cwalo
cwalo
opened on Sep 25, 2017

You'll see in the screenshot that in some cases, the cellTopLabel butts up right against the message bubble. I think exposing a method in MessagesLayoutDelegate to set the size would be ideal - similar to headerViewSize.

screen shot 2017-09-25 at 2 19 21 pm

Activity

  1. SD10 commented on Sep 25, 2017

    @SD10
    SD10
    on Sep 25, 2017
    Member

    We're going to have a slogan "We don't use properties but there's a method for everything"

  2. cwalo commented on Sep 25, 2017

    @cwalo
    cwalo
    on Sep 25, 2017
    ContributorAuthor

    As @SD10 suggested, subclassing MessagesCollectionViewLayout and setting cellTopLabelInsets in init() gets the job done.

  3. SD10 commented on Sep 25, 2017

    @SD10
    SD10
    on Sep 25, 2017
    Member

    We'll fix this by adding the UIEdgeInsets as an associated value to the LabelAlignment enum. This will allow you to set any inset dynamically. We'll then be able to remove these properties from `MessagesCollectionViewFlowLayout.

  4. SD10
    added
    enhancement
    on Sep 25, 2017
  5. SD10
    added this to the 0.9.0 milestone on Sep 25, 2017
  6. SD10
    self-assigned this
    on Sep 25, 2017

  7. cwalo commented on Sep 28, 2017

    @cwalo
    cwalo
    on Sep 28, 2017
    ContributorAuthor

    Resolved by #166

  8. cwalo
    closed this as completedon Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions