You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add copy menu for long press gesture on message bubbles #143
I'm interested in this one.
Should I take it from the 0.8.0 branch?
Is there any particular reason we are not using UITextView?
What kind of UI do you have in mind? It would be cool maybe something fancy like Telegram and WhatsApp, but Messages shows a simple action sheet as the copy control 😂
Hey @etoledom, I'm working on trying to finish up v0.8.0 now so this is probably better for v0.9.0+
I know @Ganzolo expressed interest in this and may have started working on it.
We're not using UITextView because I was advised not to -- which is good enough for me :)
As for the UI, I'm thinking something like the old iMessage/JSQMVC style. Although, the greater flexibility we can provide the better 😃
In JSQMVC, uitextview was being used. The main problem was that, when you use the UIMenuController, there was a conflict between the collection view's UIMenuController and textview's. When you want to allow data detectors, you need to set uitextview selectable. Once you set it as selectable, then it would allow data detectors, then there will be a conflict with the collection view's UIMenuController. Therefore, we couldn't have used data detectors in JSQMVC.
I think we can use the collection view's UIMenuController to copy the texts. These way we can easily copy both texts and media messages.
Just sharing some progress here. I am using following set of requirements for implementing copy :
Copy Menu should be centered above message container (a.k.a bubbles)
Message container should be the only clickable zone to display menu. Meaning clicking on white background of a message cell should not trigger this menu
Color of message should be slightly highlighted to reflect selection
Whole MessageCollectionView's scrollview should stop allowing scrolling when having menu displayed. In my tests, this prevents Copy message to be misaligned when scrolling (and also this is default behavior of most other tasks, Messages and Viber for instance).
So far the only lines I had to deactivate to start working on this feature is Long press gesture on MessageLabel.swift @SD10 would tell if it's acceptable.
Activity
etoledom commentedon Sep 22, 2017
I'm interested in this one.
Should I take it from the 0.8.0 branch?
Is there any particular reason we are not using UITextView?
What kind of UI do you have in mind? It would be cool maybe something fancy like Telegram and WhatsApp, but Messages shows a simple action sheet as the copy control 😂
SD10 commentedon Sep 22, 2017
Hey @etoledom, I'm working on trying to finish up
v0.8.0now so this is probably better forv0.9.0+I know @Ganzolo expressed interest in this and may have started working on it.
We're not using
UITextViewbecause I was advised not to -- which is good enough for me :)As for the UI, I'm thinking something like the old iMessage/JSQMVC style. Although, the greater flexibility we can provide the better 😃
etoledom commentedon Sep 22, 2017
Cool! Let’s hope @Ganzolo can tell us if he is in this 😅.
#145 is interesting for me too, I have been working a lot with maps lately.
hamzaozturk commentedon Sep 22, 2017
In JSQMVC, uitextview was being used. The main problem was that, when you use the UIMenuController, there was a conflict between the collection view's UIMenuController and textview's. When you want to allow data detectors, you need to set uitextview selectable. Once you set it as selectable, then it would allow data detectors, then there will be a conflict with the collection view's UIMenuController. Therefore, we couldn't have used data detectors in JSQMVC.
I think we can use the collection view's UIMenuController to copy the texts. These way we can easily copy both texts and media messages.
SD10 commentedon Sep 22, 2017
Awesome @hamzaozturk thanks for this clear explanation and the valuable insight ❤️
Ganzolo commentedon Sep 22, 2017
Yes, I started working on it, I am going to PR something very soon, within next couple of days.
Ganzolo commentedon Sep 22, 2017
Just sharing some progress here. I am using following set of requirements for implementing copy :
So far the only lines I had to deactivate to start working on this feature is Long press gesture on MessageLabel.swift @SD10 would tell if it's acceptable.
SD10 commentedon Sep 22, 2017
@Ganzolo Yes the long press gesture for
MessageLabelshould be used for this. Those sound like good requirements to me.SD10 commentedon Jan 11, 2018
This is resolved by #422 in MessageKit 13.0