Don't absorb exceptions in EventPublisher

muratcakir · muratcakir · commit e077e20ae14f · 2016-11-14T18:03:30.000+01:00
diff --git a/src/Libraries/SmartStore.Core/Data/Hooks/DefaultDbHookHandler.cs b/src/Libraries/SmartStore.Core/Data/Hooks/DefaultDbHookHandler.cs
@@ -129,7 +129,7 @@ public bool TriggerPreSaveHooks(IEnumerable<HookedEntity> entries, bool importan
 					// call hook
 					try
 					{
-						Logger.DebugFormat("PRE save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);
+						//Logger.DebugFormat("PRE save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);
 						hook.OnBeforeSave(e);
 						processedHooks.Add(hook);
 					}
@@ -180,7 +180,7 @@ public void TriggerPostSaveHooks(IEnumerable<HookedEntity> entries, bool importa
 					// call hook
 					try
 					{
-						Logger.DebugFormat("POST save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);
+						//Logger.DebugFormat("POST save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);
 						hook.OnAfterSave(e);
 						processedHooks.Add(hook);
 					}
diff --git a/src/Libraries/SmartStore.Services/Events/EventPublisher.cs b/src/Libraries/SmartStore.Services/Events/EventPublisher.cs
@@ -66,7 +66,7 @@ public void Publish<T>(T eventMessage)
 						var ex = t.Exception;
 						if (ex != null)
 						{
-							ex.InnerExceptions.Each(x => LogError(x));
+							ex.InnerExceptions.Each(x => Logger.Error(x));
 						}
 					}
 				});
@@ -88,15 +88,11 @@ private void PublishEvent<T>(IConsumer<T> x, T eventMessage)
 			}
 			catch (Exception ex)
 			{
-				LogError(ex);
+				Logger.Error(ex);
+				throw;
 			}
 		}
 
-		private void LogError(Exception exception)
-		{
-			Logger.Error(exception);
-		}
-
 		private void RemoveFromQueue(object eventMessage)
 		{
 			Timer timer;

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public bool TriggerPreSaveHooks(IEnumerable<HookedEntity> entries, bool importan`
`129`	`129`	`// call hook`
`130`	`130`	`try`
`131`	`131`	`{`
`132`		`- Logger.DebugFormat("PRE save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);`
	`132`	`+ //Logger.DebugFormat("PRE save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);`
`133`	`133`	`hook.OnBeforeSave(e);`
`134`	`134`	`processedHooks.Add(hook);`
`135`	`135`	`}`
`@@ -180,7 +180,7 @@ public void TriggerPostSaveHooks(IEnumerable<HookedEntity> entries, bool importa`
`180`	`180`	`// call hook`
`181`	`181`	`try`
`182`	`182`	`{`
`183`		`- Logger.DebugFormat("POST save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);`
	`183`	`+ //Logger.DebugFormat("POST save hook: {0}, State: {1}, Entity: {2}", hook.GetType().Name, e.InitialState, e.Entity.GetUnproxiedType().Name);`
`184`	`184`	`hook.OnAfterSave(e);`
`185`	`185`	`processedHooks.Add(hook);`
`186`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public void Publish<T>(T eventMessage)`
`66`	`66`	`var ex = t.Exception;`
`67`	`67`	`if (ex != null)`
`68`	`68`	`{`
`69`		`- ex.InnerExceptions.Each(x => LogError(x));`
	`69`	`+ ex.InnerExceptions.Each(x => Logger.Error(x));`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`});`
`@@ -88,15 +88,11 @@ private void PublishEvent<T>(IConsumer<T> x, T eventMessage)`
`88`	`88`	`}`
`89`	`89`	`catch (Exception ex)`
`90`	`90`	`{`
`91`		`- LogError(ex);`
	`91`	`+ Logger.Error(ex);`
	`92`	`+ throw;`
`92`	`93`	`}`
`93`	`94`	`}`
`94`	`95`
`95`		`- private void LogError(Exception exception)`
`96`		`- {`
`97`		`- Logger.Error(exception);`
`98`		`- }`
`99`		`-`
`100`	`96`	`private void RemoveFromQueue(object eventMessage)`
`101`	`97`	`{`
`102`	`98`	`Timer timer;`