Skip to content

Commit f56440b

Browse files
author
IlyaFaer
committed
add unit tests
1 parent b01c801 commit f56440b

7 files changed

Lines changed: 192 additions & 8047 deletions

File tree

google/cloud/storage/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,7 @@ def generate_signed_post_policy(
898898
)
899899
str_to_sign = base64.b64encode(policy.encode("utf-8"))
900900

901-
signature_bytes = self._credentials.sign_bytes(str_to_sign.encode("ascii"))
901+
signature_bytes = self._credentials.sign_bytes(str_to_sign)
902902
signature = binascii.hexlify(signature_bytes).decode("ascii")
903903

904904
timestamp, datestamp = get_v4_dtstamps()

tests/unit/test__signing.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -762,6 +762,22 @@ def test_bytes(self):
762762
self.assertEqual(encoded_param, "bytes")
763763

764764

765+
class TestV4Stamps(unittest.TestCase):
766+
def test_get_v4_dtstamps(self):
767+
import datetime
768+
from google.cloud.storage._signing import get_v4_dtstamps
769+
770+
with mock.patch(
771+
"google.cloud.storage._signing.NOW",
772+
return_value=datetime.datetime(2020, 3, 12, 13, 14, 15),
773+
) as now_mock:
774+
timestamp, datestamp = get_v4_dtstamps()
775+
now_mock.assert_called_once()
776+
777+
self.assertEqual(timestamp, "20200312T131415Z")
778+
self.assertEqual(datestamp, "20200312")
779+
780+
765781
_DUMMY_SERVICE_ACCOUNT = None
766782

767783

0 commit comments

Comments
 (0)