feat(bigtable): skip system test failing with emulator#1
Draft
HemangChothani wants to merge 5 commits into
Draft
feat(bigtable): skip system test failing with emulator#1HemangChothani wants to merge 5 commits into
HemangChothani wants to merge 5 commits into
Conversation
Collaborator
Author
mf2199
reviewed
Apr 8, 2020
| for table in self.tables_to_delete: | ||
| table.delete() | ||
|
|
||
| def _maybe_emulator_skip(self, message): |
Collaborator
There was a problem hiding this comment.
I'd rather give it a different name, e.g., _skip_if_emulator or so.
Collaborator
Author
There was a problem hiding this comment.
@mf2199 As you can see here to maintain consistency i put the same name of method https://github.com/q-logic/python-bigtable/blob/0134f2edfb0893260feaad31dec27cc5962914b7/tests/system.py#L835-L839
| self.assertEqual(retrieved_col_fam.gc_rule, gc_rule) | ||
|
|
||
| def test_create_table_with_split_keys(self): | ||
| self._maybe_emulator_skip("Split keys not supported by Bigtable emulator") |
Collaborator
There was a problem hiding this comment.
Split keys not are supported by Bigtable emulator``
|
|
||
| def test_read_large_cell_limit(self): | ||
| self._maybe_emulator_skip( | ||
| "Maximum grpc received message size for emulator is 4194304" |
Collaborator
There was a problem hiding this comment.
Wonder whether it's grpc or gRPC. And it's probably 4194304 bytes.
…into bigtable_issue_5
…into bigtable_issue_5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [5]