fix(irm): deprecate resource name helper methods (via synth) (googleapis#9860)

yoshi-automation · busunkim96 · commit 8f4cad209cc8 · 2019-11-20T09:42:44.000-08:00
diff --git a/irm/docs/_static/custom.css b/irm/docs/_static/custom.css
@@ -1,4 +1,4 @@
 div#python2-eol {
 	border-color: red;
 	border-width: medium;
-}
+} 
diff --git a/irm/docs/_templates/layout.html b/irm/docs/_templates/layout.html
@@ -1,3 +1,4 @@
+
 {% extends "!layout.html" %}
 {%- block content %}
 {%- if theme_fixed_sidebar|lower == 'true' %}
diff --git a/irm/google/cloud/irm_v1alpha2/gapic/incident_service_client.py b/irm/google/cloud/irm_v1alpha2/gapic/incident_service_client.py
@@ -77,7 +77,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def annotation_path(cls, project, incident, annotation):
-        """Return a fully-qualified annotation string."""
+        """DEPRECATED. Return a fully-qualified annotation string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}/annotations/{annotation}",
             project=project,
@@ -87,7 +92,12 @@ def annotation_path(cls, project, incident, annotation):
 
     @classmethod
     def artifact_path(cls, project, incident, artifact):
-        """Return a fully-qualified artifact string."""
+        """DEPRECATED. Return a fully-qualified artifact string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}/artifacts/{artifact}",
             project=project,
@@ -97,7 +107,12 @@ def artifact_path(cls, project, incident, artifact):
 
     @classmethod
     def incident_path(cls, project, incident):
-        """Return a fully-qualified incident string."""
+        """DEPRECATED. Return a fully-qualified incident string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}",
             project=project,
@@ -106,14 +121,24 @@ def incident_path(cls, project, incident):
 
     @classmethod
     def project_path(cls, project):
-        """Return a fully-qualified project string."""
+        """DEPRECATED. Return a fully-qualified project string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}", project=project
         )
 
     @classmethod
     def role_assignment_path(cls, project, incident, role_assignment):
-        """Return a fully-qualified role_assignment string."""
+        """DEPRECATED. Return a fully-qualified role_assignment string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}/roleAssignments/{role_assignment}",
             project=project,
@@ -123,14 +148,24 @@ def role_assignment_path(cls, project, incident, role_assignment):
 
     @classmethod
     def signal_path(cls, project, signal):
-        """Return a fully-qualified signal string."""
+        """DEPRECATED. Return a fully-qualified signal string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/signals/{signal}", project=project, signal=signal
         )
 
     @classmethod
     def subscription_path(cls, project, incident, subscription):
-        """Return a fully-qualified subscription string."""
+        """DEPRECATED. Return a fully-qualified subscription string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}/subscriptions/{subscription}",
             project=project,
@@ -140,7 +175,12 @@ def subscription_path(cls, project, incident, subscription):
 
     @classmethod
     def tag_path(cls, project, incident, tag):
-        """Return a fully-qualified tag string."""
+        """DEPRECATED. Return a fully-qualified tag string."""
+        warnings.warn(
+            "Resource name helper functions are deprecated.",
+            PendingDeprecationWarning,
+            stacklevel=1,
+        )
         return google.api_core.path_template.expand(
             "projects/{project}/incidents/{incident}/tags/{tag}",
             project=project,
diff --git a/irm/synth.metadata b/irm/synth.metadata
@@ -1,26 +1,26 @@
 {
-  "updateTime": "2019-10-05T12:26:52.725480Z",
+  "updateTime": "2019-11-20T13:23:46.362060Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.38.0",
-        "dockerImage": "googleapis/artman@sha256:0d2f8d429110aeb8d82df6550ef4ede59d40df9062d260a1580fce688b0512bf"
+        "version": "0.42.1",
+        "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "ceb8e2fb12f048cc94caae532ef0b4cf026a78f3",
-        "internalRef": "272971705"
+        "sha": "16543773103e2619d2b5f52456264de5bb9be104",
+        "internalRef": "281423227"
       }
     },
     {
       "template": {
         "name": "python_library",
         "origin": "synthtool.gcp",
-        "version": "2019.5.2"
+        "version": "2019.10.17"
       }
     }
   ],

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+`
`1`	`2`	`{% extends "!layout.html" %}`
`2`	`3`	`{%- block content %}`
`3`	`4`	`{%- if theme_fixed_sidebar\|lower == 'true' %}`
Original file line number	Diff line number	Diff line change
`@@ -1,26 +1,26 @@`
`1`	`1`	`{`
`2`		`- "updateTime": "2019-10-05T12:26:52.725480Z",`
	`2`	`+ "updateTime": "2019-11-20T13:23:46.362060Z",`
`3`	`3`	`"sources": [`
`4`	`4`	`{`
`5`	`5`	`"generator": {`
`6`	`6`	`"name": "artman",`
`7`		`- "version": "0.38.0",`
`8`		`- "dockerImage": "googleapis/artman@sha256:0d2f8d429110aeb8d82df6550ef4ede59d40df9062d260a1580fce688b0512bf"`
	`7`	`+ "version": "0.42.1",`
	`8`	`+ "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"`
`9`	`9`	`}`
`10`	`10`	`},`
`11`	`11`	`{`
`12`	`12`	`"git": {`
`13`	`13`	`"name": "googleapis",`
`14`	`14`	`"remote": "https://github.com/googleapis/googleapis.git",`
`15`		`- "sha": "ceb8e2fb12f048cc94caae532ef0b4cf026a78f3",`
`16`		`- "internalRef": "272971705"`
	`15`	`+ "sha": "16543773103e2619d2b5f52456264de5bb9be104",`
	`16`	`+ "internalRef": "281423227"`
`17`	`17`	`}`
`18`	`18`	`},`
`19`	`19`	`{`
`20`	`20`	`"template": {`
`21`	`21`	`"name": "python_library",`
`22`	`22`	`"origin": "synthtool.gcp",`
`23`		`- "version": "2019.5.2"`
	`23`	`+ "version": "2019.10.17"`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`	`],`