Skip to content

Commit 7b95e69

Browse files
committed
Fixes caching of etree modules (do not cache at the __init__ level, let the etre submodule do its own cachine based on the implementation)
--HG-- extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%40842
1 parent 400ad9d commit 7b95e69

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/html5lib/treebuilders/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,6 @@ def getTreeBuilder(treeType, implementation=None, **kwargs):
6060
treeBuilderCache[treeType] = soup.TreeBuilder
6161
elif treeType == "etree":
6262
import etree
63-
treeBuilderCache[treeType] = etree.getETreeModule(implementation, **kwargs).TreeBuilder
63+
# XXX: NEVER cache here, caching is done in the etree submodule
64+
return etree.getETreeModule(implementation, **kwargs).TreeBuilder
6465
return treeBuilderCache.get(treeType)

0 commit comments

Comments
 (0)