Skip to content

Commit 36a90f5

Browse files
committed
Clean up test serialization of no-name doctype case
--HG-- extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%40870
1 parent eaea9f3 commit 36a90f5

4 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/html5lib/treebuilders/dom.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,10 @@ def testSerializer(element):
119119
rv = []
120120
def serializeElement(element, indent=0):
121121
if element.nodeType == Node.DOCUMENT_TYPE_NODE:
122-
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.name))
122+
if element.name:
123+
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.name))
124+
else:
125+
rv.append("|%s<!DOCTYPE>"%(' '*indent))
123126
elif element.nodeType == Node.DOCUMENT_NODE:
124127
rv.append("#document")
125128
elif element.nodeType == Node.DOCUMENT_FRAGMENT_NODE:

src/html5lib/treebuilders/etree.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,10 @@ def serializeElement(element, indent=0):
151151
if not(hasattr(element, "tag")):
152152
element = element.getroot()
153153
if element.tag == "<!DOCTYPE>":
154-
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.text))
154+
if element.text:
155+
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.text))
156+
else:
157+
rv.append("|%s<!DOCTYPE>"%(' '*indent))
155158
elif element.tag == "<DOCUMENT_ROOT>":
156159
rv.append("#document")
157160
if element.text:

src/html5lib/treebuilders/simpletree.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,10 @@ def __init__(self, name):
109109
Node.__init__(self, name)
110110

111111
def __unicode__(self):
112-
return "<!DOCTYPE %s>" % self.name
112+
if self.name:
113+
return "<!DOCTYPE %s>" % self.name
114+
else:
115+
return "<!DOCTYPE>"
113116

114117
toxml = __unicode__
115118

src/html5lib/treebuilders/soup.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,10 @@ def testSerializer(element):
133133
rv = []
134134
def serializeElement(element, indent=0):
135135
if isinstance(element, Declaration):
136-
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.string))
136+
if element.string:
137+
rv.append("|%s<!DOCTYPE %s>"%(' '*indent, element.string))
138+
else:
139+
rv.append("|%s<!DOCTYPE>"%(' '*indent))
137140
elif isinstance(element, BeautifulSoup):
138141
if element.name == "[document_fragment]":
139142
rv.append("#document-fragment")

0 commit comments

Comments
 (0)