fix up some comments and revert the change to utils.py because it made it two times slower

annevk · annevk · commit 1c35bfa9d4d7 · 2006-12-25T10:58:32.000Z
--HG--
extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%40336
diff --git a/src/constants.py b/src/constants.py
@@ -3,7 +3,7 @@
 try:
     frozenset
 except NameError:
-    #Import from the sets module for python 2.3
+    # Import from the sets module for python 2.3
     from sets import Set as set
     from sets import ImmutableSet as frozenset
 
@@ -129,7 +129,7 @@
 digits = frozenset(string.digits)
 hexDigits = frozenset(string.hexdigits)
 
-#Heading elements need to be ordered 
+# Heading elements need to be ordered 
 headingElements = (
     "h1",
     "h2",
diff --git a/src/parser.py b/src/parser.py
@@ -1,7 +1,7 @@
 try:
     frozenset
 except NameError:
-    #Import from the sets module for python 2.3
+    # Import from the sets module for python 2.3
     from sets import Set as set
     from sets import ImmutableSet as frozenset
 
diff --git a/src/tokenizer.py b/src/tokenizer.py
@@ -1,7 +1,7 @@
 try:
     frozenset
 except NameError:
-    #Import from the sets module for python 2.3
+    # Import from the sets module for python 2.3
     from sets import Set as set
     from sets import ImmutableSet as frozenset
 
diff --git a/src/utils.py b/src/utils.py
@@ -19,12 +19,17 @@ class MethodDispatcher(dict):
     """
 
     def __init__(self, items=()):
+        # Using _dictEntries instead of directly assigning to self is about
+        # twice as fast. Please do careful performance testing before changing
+        # anything here.
+        _dictEntries = []
         for name,value in items:
             if type(name) in (list, tuple, frozenset, set):
                 for item in name:
-                    self[item] = value
+                    _dictEntries.append((item, value))
             else:
-                self[name] = value
+                _dictEntries.append((name, value))
+        dict.__init__(self, _dictEntries)
         self.default = None
 
     def __getitem__(self, key):
