Skip to content

Commit 0335f27

Browse files
committed
Don't try to dereference paths or URIs in inputstream.py
--HG-- extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%40446
1 parent 3186ecf commit 0335f27

3 files changed

Lines changed: 14 additions & 13 deletions

File tree

parse.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,21 @@ def parse():
2828

2929
try:
3030
f = args[-1]
31+
# Try opening from the internet
32+
if f.startswith('http://'):
33+
try:
34+
import urllib
35+
f = urllib.urlopen(f).read()
36+
except: pass
37+
else:
38+
try:
39+
# Try opening from file system
40+
f = open(f)
41+
except IOError: pass
3142
except IndexError:
3243
print "No filename provided. Use -h for help"
3344
sys.exit(1)
45+
3446
if opts.treebuilder is not None:
3547
try:
3648
treebuilder = __import__("treebuilders." + opts.treebuilder,

src/inputstream.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,6 @@ def openStream(self, source):
7474
if hasattr(source, 'read'):
7575
stream = source
7676
else:
77-
# Try opening from file system
78-
try:
79-
return open(source)
80-
except: pass
81-
82-
# Try opening from the internet
83-
try:
84-
if source.startswith('http://'):
85-
import urllib
86-
source = urllib.urlopen(source).read()
87-
except: pass
88-
8977
# Otherwise treat source as a string and convert to a file object
9078
import cStringIO
9179
stream = cStringIO.StringIO(str(source))

tests/test_parser.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@
1212
import html5parser
1313
#Run tests over all treebuilders
1414
#XXX - it would be nice to automate finding all treebuilders or to allow running just one
15+
1516
from treebuilders import simpletree, etree, dom
1617

17-
treetypes = {"simpletree":simpletree.TreeBuilder,
18+
treetypes = {"simpletree":simpletree.TreeBuilder,
1819
"ElementTree":etree.TreeBuilder,
1920
"DOM":dom.TreeBuilder}
2021

0 commit comments

Comments
 (0)