dev - do not set ELECTRON_DEFAULT_ERROR_MODE on windows

bpasero · bpasero · commit 335dd17b8e64 · 2020-04-15T19:37:36.000+02:00
diff --git a/scripts/code-cli.bat b/scripts/code-cli.bat
@@ -30,7 +30,7 @@ if not exist out yarn compile
 set ELECTRON_RUN_AS_NODE=1
 set NODE_ENV=development
 set VSCODE_DEV=1
-set ELECTRON_DEFAULT_ERROR_MODE=1
+REM set ELECTRON_DEFAULT_ERROR_MODE=1 TODO@ben to investigate if this helps with builds reporting stacks if renderer crashes
 set ELECTRON_ENABLE_LOGGING=1
 set ELECTRON_ENABLE_STACK_DUMPING=1
 
diff --git a/scripts/code.bat b/scripts/code.bat
@@ -29,7 +29,7 @@ if not exist out yarn compile
 set NODE_ENV=development
 set VSCODE_DEV=1
 set VSCODE_CLI=1
-set ELECTRON_DEFAULT_ERROR_MODE=1
+REM set ELECTRON_DEFAULT_ERROR_MODE=1 TODO@ben to investigate if this helps with builds reporting stacks if renderer crashes
 set ELECTRON_ENABLE_LOGGING=1
 set ELECTRON_ENABLE_STACK_DUMPING=1
 set VSCODE_LOGS=
