Tweak -Xlint warnings

ejona86 · ejona86 · commit 641cb357c68c · 2016-05-24T15:04:07.000-07:00
This now catches a few more places we needed -Xlint:-options.
InProcessSocketAddress is technically already in our stable API, so I
maintained its current serialVersionUID.
diff --git a/benchmarks/build.gradle b/benchmarks/build.gradle
@@ -45,6 +45,10 @@ dependencies {
             libraries.math
 }
 
+compileJmhJava {
+  options.compilerArgs = compileJava.options.compilerArgs
+}
+
 configureProtoCompilation()
 
 def vmArgs = [
diff --git a/build.gradle b/build.gradle
@@ -30,11 +30,15 @@ subprojects {
     }
 
     [compileJava, compileTestJava].each() {
-        it.options.compilerArgs += ["-Xlint:unchecked", "-Xlint:deprecation", "-Xlint:-options",
-            "-Xlint:rawtypes"]
+        it.options.compilerArgs += ["-Xlint:all", "-Xlint:-options"]
         it.options.encoding = "UTF-8"
     }
 
+    compileTestJava {
+      // serialVersionUID is basically guaranteed to be useless in our tests
+      options.compilerArgs += ["-Xlint:-serial"]
+    }
+
     jar.manifest {
         attributes('Implementation-Title': name,
                 'Implementation-Version': version,
diff --git a/compiler/build.gradle b/compiler/build.gradle
@@ -135,7 +135,12 @@ sourceSets {
 
 compileTestLiteJava {
   // Protobuf-generated Lite produces quite a few warnings.
-  it.options.compilerArgs.removeAll(["-Xlint:unchecked", "-Xlint:rawtypes"])
+  options.compilerArgs = compileTestJava.options.compilerArgs +
+      ["-Xlint:-unchecked", "-Xlint:-rawtypes"]
+}
+
+compileTestNanoJava {
+  options.compilerArgs = compileTestJava.options.compilerArgs
 }
 
 protobuf {
diff --git a/core/src/main/java/io/grpc/ManagedChannelProvider.java b/core/src/main/java/io/grpc/ManagedChannelProvider.java
@@ -133,6 +133,8 @@ protected static boolean isAndroid() {
   protected abstract ManagedChannelBuilder<?> builderForTarget(String target);
 
   public static final class ProviderNotFoundException extends RuntimeException {
+    private static final long serialVersionUID = 1;
+
     public ProviderNotFoundException(String msg) {
       super(msg);
     }
diff --git a/core/src/main/java/io/grpc/inprocess/InProcessSocketAddress.java b/core/src/main/java/io/grpc/inprocess/InProcessSocketAddress.java
@@ -37,6 +37,8 @@
  * Custom SocketAddress class for {@link InProcessTransport}.
  */
 public class InProcessSocketAddress extends SocketAddress {
+  private static final long serialVersionUID = -2803441206326023474L;
+
   private final String name;
 
   public InProcessSocketAddress(String name) {

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,10 @@ dependencies {`
`45`	`45`	`libraries.math`
`46`	`46`	`}`
`47`	`47`
	`48`	`+compileJmhJava {`
	`49`	`+ options.compilerArgs = compileJava.options.compilerArgs`
	`50`	`+}`
	`51`	`+`
`48`	`52`	`configureProtoCompilation()`
`49`	`53`
`50`	`54`	`def vmArgs = [`
Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,8 @@ protected static boolean isAndroid() {`
`133`	`133`	`protected abstract ManagedChannelBuilder<?> builderForTarget(String target);`
`134`	`134`
`135`	`135`	`public static final class ProviderNotFoundException extends RuntimeException {`
	`136`	`+ private static final long serialVersionUID = 1;`
	`137`	`+`
`136`	`138`	`public ProviderNotFoundException(String msg) {`
`137`	`139`	`super(msg);`
`138`	`140`	`}`