Merge pull request mohammadKarimi#104 from mohammadKarimi/103-remove-setting-the-shortlink-in-redis-cache-on-insert

mohammadKarimi · web-flow · commit 7b5aec8f851a · 2024-02-17T16:55:33.000+03:30
Remove pushing ShortCode into cache on Insert use-case.
diff --git a/src/SwiftLink.Application/UseCases/Links/Commands/GenerateShortCode/GenerateShortCodeCommandHandler.cs b/src/SwiftLink.Application/UseCases/Links/Commands/GenerateShortCode/GenerateShortCodeCommandHandler.cs
@@ -2,19 +2,16 @@
 using SwiftLink.Application.Common;
 using SwiftLink.Application.Common.Interfaces;
 using SwiftLink.Application.Dtos;
-using System.Text.Json;
 
 namespace SwiftLink.Application.UseCases.Links.Commands;
 
 public class GenerateShortCodeCommandHandler(IApplicationDbContext dbContext,
-                                             ICacheProvider cacheProvider,
                                              IShortCodeGenerator codeGenerator,
                                              IOptions<AppSettings> options,
                                              ISharedContext sharedContext)
     : IRequestHandler<GenerateShortCodeCommand, Result<LinksDto>>
 {
     private readonly IApplicationDbContext _dbContext = dbContext;
-    private readonly ICacheProvider _cache = cacheProvider;
     private readonly IShortCodeGenerator _codeGenerator = codeGenerator;
     private readonly ISharedContext _sharedContext = sharedContext;
     private readonly IOptions<AppSettings> _options = options;
@@ -39,19 +36,16 @@ public async Task<Result<LinksDto>> Handle(GenerateShortCodeCommand request,
         linkTable.Add(link);
         var dbResult = await _dbContext.SaveChangesAsync(cancellationToken);
 
-        if (dbResult.IsFailure)
-            return Result.Failure<LinksDto>(CommonMessages.Database.InsertFailed);
-
-        await _cache.Set(link.ShortCode, JsonSerializer.Serialize(link), link.ExpirationDate);
-
-        return Result.Success(new LinksDto()
-        {
-            ExpirationDate = link.ExpirationDate,
-            IsBanned = link.IsBanned,
-            ShortCode = link.ShortCode,
-            OriginalUrl = link.OriginalUrl,
-            Description = link.Description,
-            LinkdId = link.Id
-        });
+        return dbResult.IsFailure
+            ? Result.Failure<LinksDto>(CommonMessages.Database.InsertFailed)
+            : Result.Success(new LinksDto()
+            {
+                ExpirationDate = link.ExpirationDate,
+                IsBanned = link.IsBanned,
+                ShortCode = link.ShortCode,
+                OriginalUrl = link.OriginalUrl,
+                Description = link.Description,
+                LinkdId = link.Id
+            });
     }
 }
