Framework: introduce Framework/Foundation module

ktf · ktf · commit fbb50b2a60dc · 2019-03-15T20:09:24.000+01:00
This is to be used for any helper or compatibility macro which
relies solely on C++17 and platform specific headers. It should
not have any external dependency.
diff --git a/Framework/CMakeLists.txt b/Framework/CMakeLists.txt
@@ -6,3 +6,4 @@ if(ARROW_FOUND)
 add_subdirectory(ArrowTests)
 endif()
 add_subdirectory(DebugGUI)
+add_subdirectory(Foundation)
diff --git a/Framework/Foundation/CMakeLists.txt b/Framework/Foundation/CMakeLists.txt
@@ -0,0 +1,14 @@
+# Copyright CERN and copyright holders of ALICE O2. This software is
+# distributed under the terms of the GNU General Public License v3 (GPL
+# Version 3), copied verbatim in the file "COPYING".
+#
+# See http://alice-o2.web.cern.ch/ for full licensing information.
+#
+# In applying this license CERN does not waive the privileges and immunities
+# granted to it by virtue of its status as an Intergovernmental Organization
+# or submit itself to any jurisdiction.
+
+set(MODULE_NAME "FrameworkFoundation")
+
+set(MODULE_BUCKET_NAME O2FrameworkFoundation_bucket)
+
diff --git a/Framework/Foundation/README.md b/Framework/Foundation/README.md
@@ -0,0 +1,3 @@
+## O2 Framework Foundation
+
+Nothing but pure C++ helpers go here. No dependencies allowed.
diff --git a/Framework/Foundation/include/Framework/CompilerBuiltins.h b/Framework/Foundation/include/Framework/CompilerBuiltins.h
@@ -0,0 +1,21 @@
+// Copyright CERN and copyright holders of ALICE O2. This software is
+// distributed under the terms of the GNU General Public License v3 (GPL
+// Version 3), copied verbatim in the file "COPYING".
+//
+// See http://alice-o2.web.cern.ch/license for full licensing information.
+//
+// In applying this license CERN does not waive the privileges and immunities
+// granted to it by virtue of its status as an Intergovernmental Organization
+// or submit itself to any jurisdiction.
+
+// Compatibility layer for a few common builtins found in different compilers.
+// These are trivial and the goal is to make sure we can compile on non GCC /
+// clang compilers if requested.
+
+#if __GNUC__
+#define O2_BUILTIN_UNREACHABLE __builtin_unreachable
+#elif __clang__
+#define O2_BUILTIN_UNREACHABLE __builtin_unreachable
+#else
+#define O2_BUILTIN_UNREACHABLE
+#endif
diff --git a/cmake/O2Dependencies.cmake b/cmake/O2Dependencies.cmake
@@ -172,6 +172,7 @@ o2_define_bucket(
   glfw_bucket
 
   DEPENDENCIES
+  O2FrameworkFoundation_bucket
   ${GLFW_LIBRARIES}
 
   INCLUDE_DIRECTORIES
@@ -181,6 +182,9 @@ o2_define_bucket(
 o2_define_bucket(
   NAME
   headless_bucket
+
+  DEPENDENCIES
+  O2FrameworkFoundation_bucket
 )
 
 o2_define_bucket(
@@ -289,12 +293,21 @@ o2_define_bucket(
     ${InfoLogger_INCLUDE_DIRS}
 )
 
+o2_define_bucket(
+    NAME
+    O2FrameworkFoundation_bucket
+
+    INCLUDE_DIRECTORIES
+    ${CMAKE_SOURCE_DIR}/Framework/Foundation/include
+)
+
 o2_define_bucket(
     NAME
     O2FrameworkCore_bucket
 
     DEPENDENCIES
     arrow_bucket
+    O2FrameworkFoundation_bucket
     O2DeviceApplication_bucket
     common_utils_bucket
     ROOTDataFrame

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+## O2 Framework Foundation`
	`2`	`+`
	`3`	`+Nothing but pure C++ helpers go here. No dependencies allowed.`