Skip to content

Commit dde254b

Browse files
[[ Bug 15619 ]] Update LIBRARY_EXPORT definition for iOS database externals, so that their symbols are not hidden (which is the default in the Gypified build)
1 parent 072b772 commit dde254b

7 files changed

Lines changed: 12 additions & 28 deletions

File tree

docs/notes/bugfix-15619.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# Opening sqlite on iOS return "revdberror,invalid database type"

docs/notes/bugfix-15626.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# Attempting to connect to Oracle database results in "revdberr,invalid database type"

revdb/src/dbdrivercommon.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */
1818

1919
#if defined(_WINDOWS) || defined(_WINDOWS_SERVER)
2020
#define LIBRARY_EXPORT __declspec(dllexport)
21-
#elif defined(_MACOSX) || defined (_MAC_SERVER)
22-
#define LIBRARY_EXPORT
23-
#elif defined(_LINUX) || defined (_LINUX_SERVER)
24-
#define LIBRARY_EXPORT
25-
#elif defined(TARGET_SUBPLATFORM_IPHONE) || defined(TARGET_SUBPLATFORM_ANDROID)
26-
#define LIBRARY_EXPORT
21+
#else
22+
#define LIBRARY_EXPORT __attribute__((__visibility__("default")))
2723
#endif
2824

2925
// Default implementations for DBField

revdb/src/dbmysqlapi.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */
1818

1919
#if defined(_WINDOWS)
2020
#define LIBRARY_EXPORT __declspec(dllexport)
21-
#elif defined(_MACOSX)
22-
#define LIBRARY_EXPORT
23-
#elif defined(_LINUX)
24-
#define LIBRARY_EXPORT
25-
#elif defined(TARGET_SUBPLATFORM_IPHONE) || defined(TARGET_SUBPLATFORM_ANDROID)
26-
#define LIBRARY_EXPORT
21+
#else
22+
#define LIBRARY_EXPORT __attribute__((__visibility__("default")))
2723
#endif
2824

2925
unsigned int *DBObject::idcounter = NULL;

revdb/src/dbodbcapi.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */
1818

1919
#if defined(_WINDOWS)
2020
#define LIBRARY_EXPORT __declspec(dllexport)
21-
#elif defined(_MACOSX)
22-
#define LIBRARY_EXPORT
23-
#elif defined(_LINUX)
24-
#define LIBRARY_EXPORT
21+
#else
22+
#define LIBRARY_EXPORT __attribute__((__visibility__("default")))
2523
#endif
2624

2725
unsigned int *DBObject::idcounter = NULL;

revdb/src/dbpostgresqlapi.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */
1818

1919
#if defined(_WINDOWS)
2020
#define LIBRARY_EXPORT __declspec(dllexport)
21-
#elif defined(_MACOSX)
22-
#define LIBRARY_EXPORT
23-
#elif defined(_LINUX)
24-
#define LIBRARY_EXPORT
25-
#elif defined(TARGET_PLATFORM_MOBILE) && defined(TARGET_SUBPLATFORM_IPHONE)
26-
#define LIBRARY_EXPORT
21+
#else
22+
#define LIBRARY_EXPORT __attribute__((__visibility__("default")))
2723
#endif
2824

2925
unsigned int *DBObject::idcounter = NULL;

revdb/src/dbsqliteapi.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */
1818

1919
#if defined(_WINDOWS)
2020
#define LIBRARY_EXPORT __declspec(dllexport)
21-
#elif defined(_MACOSX)
22-
#define LIBRARY_EXPORT
23-
#elif defined(_LINUX)
24-
#define LIBRARY_EXPORT
25-
#elif defined(TARGET_SUBPLATFORM_IPHONE) || defined(TARGET_SUBPLATFORM_ANDROID)
26-
#define LIBRARY_EXPORT
21+
#else
22+
#define LIBRARY_EXPORT __attribute__((__visibility__("default")))
2723
#endif
2824

2925
unsigned int *DBObject::idcounter = NULL;

0 commit comments

Comments
 (0)