[ CID 120052 ] Fix resource leak

livecodeali · livecodeali · commit 564c13af96e6 · 2016-03-23T14:15:58.000Z
Ensure that ParserMatchConstant always increases the refcount of
its returned value, so that the caller can release safely.
diff --git a/lcidlc/src/Parser.cpp b/lcidlc/src/Parser.cpp
@@ -314,7 +314,7 @@ static bool ParserMatchConstant(ParserRef self, ValueRef& r_value)
 	self -> position = t_token -> start;
 	
     if (!t_is_bool)
-        r_value = t_token -> value;
+        r_value = ValueRetain(t_token -> value);
 	
 	return true;
 }
@@ -835,10 +835,12 @@ static bool ParserReduceParameterDefinition(ParserRef self)
                 return false;
     }
 	
-	if (!InterfaceDefineHandlerParameter(self -> interface, t_position, t_parameter_type, t_name, t_type, t_is_optional, t_default))
-		return false;
-
-	return true;
+    bool t_success;
+    t_success = InterfaceDefineHandlerParameter(self -> interface, t_position, t_parameter_type, t_name, t_type, t_is_optional, t_default);
+    
+    ValueRelease(t_default);
+    
+    return t_success;
 }
 
 static bool ParserReduceReturnDefinition(ParserRef self)
