lib: fix consistency of methods that emit warnings

kuriyosh · Linkgoron · commit eadb217a491b · 2022-01-31T11:12:14.000+02:00
PR-URL: nodejs#41249 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
diff --git a/lib/internal/dns/utils.js b/lib/internal/dns/utils.js
@@ -178,18 +178,16 @@ function validateHints(hints) {
 }
 
 let invalidHostnameWarningEmitted = false;
-
 function emitInvalidHostnameWarning(hostname) {
-  if (invalidHostnameWarningEmitted) {
-    return;
+  if (!invalidHostnameWarningEmitted) {
+    process.emitWarning(
+      `The provided hostname "${hostname}" is not a valid ` +
+      'hostname, and is supported in the dns module solely for compatibility.',
+      'DeprecationWarning',
+      'DEP0118'
+    );
+    invalidHostnameWarningEmitted = true;
   }
-  invalidHostnameWarningEmitted = true;
-  process.emitWarning(
-    `The provided hostname "${hostname}" is not a valid ` +
-    'hostname, and is supported in the dns module solely for compatibility.',
-    'DeprecationWarning',
-    'DEP0118'
-  );
 }
 
 let typeCoercionWarningEmitted = false;
