Ensure languageServer value is valid, send event during activate (#13064)

jakebailey · web-flow · commit 986980aaa644 · 2020-07-21T10:08:02.000-07:00
diff --git a/src/client/activation/activationService.ts b/src/client/activation/activationService.ts
@@ -188,7 +188,6 @@ export class LanguageServerExtensionActivationService
         // Configuration is non-default, so `languageServer` should be present.
         const configurationService = this.serviceContainer.get<IConfigurationService>(IConfigurationService);
         const lstType = configurationService.getSettings(this.resource).languageServer;
-        this.sendTelemetryForChosenLanguageServer(lstType).ignoreErrors();
         return lstType === LanguageServerType.Jedi;
     }
 
@@ -253,6 +252,8 @@ export class LanguageServerExtensionActivationService
                 break;
         }
 
+        this.sendTelemetryForChosenLanguageServer(serverType).ignoreErrors();
+
         await this.logStartup(serverType);
         let server = this.serviceContainer.get<ILanguageServerActivator>(ILanguageServerActivator, serverType);
         try {
diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts
@@ -231,11 +231,12 @@ export class PythonSettings implements IPythonSettings {
             pythonSettings.get<boolean>('autoUpdateLanguageServer', true)
         )!;
 
-        let ls = pythonSettings.get<LanguageServerType>('languageServer');
-        if (!ls) {
+        let ls = pythonSettings.get<LanguageServerType>('languageServer') ?? LanguageServerType.Jedi;
+        ls = systemVariables.resolveAny(ls);
+        if (!Object.values(LanguageServerType).includes(ls)) {
             ls = LanguageServerType.Jedi;
         }
-        this.languageServer = systemVariables.resolveAny(ls)!;
+        this.languageServer = ls;
 
         // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
         this.jediPath = systemVariables.resolveAny(pythonSettings.get<string>('jediPath'))!;
diff --git a/src/test/common/configSettings/configSettings.unit.test.ts b/src/test/common/configSettings/configSettings.unit.test.ts
@@ -193,6 +193,31 @@ suite('Python Settings', async () => {
         config.verifyAll();
     });
 
+    function testLanguageServer(languageServer: LanguageServerType, expectedValue: LanguageServerType) {
+        test(languageServer, () => {
+            expected.pythonPath = 'python3';
+            expected.languageServer = languageServer;
+            initializeConfig(expected);
+            config
+                .setup((c) => c.get<LanguageServerType>('languageServer'))
+                .returns(() => expected.languageServer)
+                .verifiable(TypeMoq.Times.once());
+
+            settings.update(config.object);
+
+            expect(settings.languageServer).to.be.equal(expectedValue);
+            config.verifyAll();
+        });
+    }
+
+    suite('languageServer settings', async () => {
+        Object.values(LanguageServerType).forEach(async (languageServer) => {
+            testLanguageServer(languageServer, languageServer);
+        });
+
+        testLanguageServer('invalid' as LanguageServerType, LanguageServerType.Jedi);
+    });
+
     function testExperiments(enabled: boolean) {
         expected.pythonPath = 'python3';
         // tslint:disable-next-line:no-any

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,6 @@ export class LanguageServerExtensionActivationService`
`188`	`188`	// Configuration is non-default, so `languageServer` should be present.
`189`	`189`	`const configurationService = this.serviceContainer.get<IConfigurationService>(IConfigurationService);`
`190`	`190`	`const lstType = configurationService.getSettings(this.resource).languageServer;`
`191`		`- this.sendTelemetryForChosenLanguageServer(lstType).ignoreErrors();`
`192`	`191`	`return lstType === LanguageServerType.Jedi;`
`193`	`192`	`}`
`194`	`193`
`@@ -253,6 +252,8 @@ export class LanguageServerExtensionActivationService`
`253`	`252`	`break;`
`254`	`253`	`}`
`255`	`254`
	`255`	`+ this.sendTelemetryForChosenLanguageServer(serverType).ignoreErrors();`
	`256`	`+`
`256`	`257`	`await this.logStartup(serverType);`
`257`	`258`	`let server = this.serviceContainer.get<ILanguageServerActivator>(ILanguageServerActivator, serverType);`
`258`	`259`	`try {`