http_request: Remove uploaded files in destructor

LeSpocky · LeSpocky · commit 283f73c2f001 · 2022-04-07T15:45:50.000+02:00
If the user needs those files, she should copy/move theme in the request handler. References: etr#264 Signed-off-by: Alexander Dahl <ada@thorsis.com>
diff --git a/src/http_request.cpp b/src/http_request.cpp
@@ -256,4 +256,13 @@ std::ostream &operator<< (std::ostream &os, const http_request &r) {
     return os;
 }
 
+http_request::~http_request() {
+    for ( const auto &file_key : this->get_files() ) {
+        for ( const auto &files : file_key.second ) {
+            // C++17 has std::filesystem::remove()
+            remove(files.second.get_file_system_file_name().c_str());
+        }
+    }
+}
+
 }  // namespace httpserver
diff --git a/src/httpserver/http_request.hpp b/src/httpserver/http_request.hpp
@@ -46,6 +46,8 @@ struct MHD_Connection;
 
 namespace httpserver {
 
+namespace details { struct modded_request; }
+
 /**
  * Class representing an abstraction for an Http Request. It is used from classes using these apis to receive information through http protocol.
 **/
@@ -254,6 +256,8 @@ class http_request {
      http_request& operator=(const http_request& b) = default;
      http_request& operator=(http_request&& b) = default;
 
+     ~http_request();
+
      std::string path;
      std::string method;
      std::map<std::string, std::string, http::arg_comparator> args;
@@ -356,6 +360,7 @@ class http_request {
      const std::map<std::string, std::string, http::header_comparator> get_headerlike_values(enum MHD_ValueKind kind) const;
 
      friend class webserver;
+     friend struct details::modded_request;
 };
 
 std::ostream &operator<< (std::ostream &os, const http_request &r);
