add unit test

halibobo1205 · halibobo1205 · commit e79faaecc7d5 · 2021-08-17T16:02:59.000+08:00
diff --git a/plugins/src/main/java/org/tron/plugins/ArchiveManifest.java b/plugins/src/main/java/org/tron/plugins/ArchiveManifest.java
@@ -56,15 +56,6 @@ public class ArchiveManifest implements Callable<Boolean> {
 
   private static final int CPUS  = Runtime.getRuntime().availableProcessors();
 
-  private static final ThreadPoolExecutor EXECUTOR = new ThreadPoolExecutor(
-      CPUS, 16 * CPUS, 1, TimeUnit.MINUTES,
-      new ArrayBlockingQueue<>(CPUS, true), Executors.defaultThreadFactory(),
-      new ThreadPoolExecutor.CallerRunsPolicy());
-
-  static {
-    EXECUTOR.allowCoreThreadTimeOut(true);
-  }
-
   public ArchiveManifest(String src, String name, int maxManifestSize, int maxBatchSize) {
     this.name = name;
     this.srcDbPath = Paths.get(src, name);
@@ -96,20 +87,27 @@ public static org.iq80.leveldb.Options newDefaultLevelDbOptions() {
   }
 
   public static void main(String[] args) {
+    int code = run(args);
+    logger.info("exit code {}.", code);
+    System.out.printf("exit code %d.\n", code);
+    System.exit(code);
+  }
+
+  public static int run(String[] args) {
     Args parameters = new Args();
     JCommander jc = JCommander.newBuilder()
         .addObject(parameters)
         .build();
     jc.parse(args);
     if (parameters.help) {
       jc.usage();
-      return;
+      return 0;
     }
 
     File dbDirectory = new File(parameters.databaseDirectory);
     if (!dbDirectory.exists()) {
       logger.info("Directory {} does not exist.", parameters.databaseDirectory);
-      return;
+      return 404;
     }
 
     List<File> files = Arrays.stream(Objects.requireNonNull(dbDirectory.listFiles()))
@@ -118,12 +116,19 @@ public static void main(String[] args) {
 
     if (files.isEmpty()) {
       logger.info("Directory {} does not contain any database.", parameters.databaseDirectory);
-      return;
+      return 0;
     }
     final long time = System.currentTimeMillis();
     final List<Future<Boolean>> res = new ArrayList<>();
+    final ThreadPoolExecutor executor = new ThreadPoolExecutor(
+        CPUS, 16 * CPUS, 1, TimeUnit.MINUTES,
+        new ArrayBlockingQueue<>(CPUS, true), Executors.defaultThreadFactory(),
+        new ThreadPoolExecutor.CallerRunsPolicy());
+
+    executor.allowCoreThreadTimeOut(true);
+
     files.forEach(f -> res.add(
-        EXECUTOR.submit(new ArchiveManifest(parameters.databaseDirectory, f.getName(),
+        executor.submit(new ArchiveManifest(parameters.databaseDirectory, f.getName(),
             parameters.maxManifestSize, parameters.maxBatchSize))));
     int fails = res.size();
 
@@ -140,15 +145,15 @@ public static void main(String[] args) {
       }
     }
 
-    EXECUTOR.shutdown();
+    executor.shutdown();
     logger.info("DatabaseDirectory:{}, maxManifestSize:{}, maxBatchSize:{},"
             + "database reopen use {} seconds total.",
         parameters.databaseDirectory, parameters.maxManifestSize, parameters.maxBatchSize,
         (System.currentTimeMillis() - time) / 1000);
     if (fails > 0) {
       logger.error("Failed!!!!!!!!!!!!!!!!!!!!!!!! size:{}", fails);
     }
-    System.exit(fails);
+    return fails;
   }
 
   public void open() throws IOException {
diff --git a/plugins/src/test/java/org/tron/plugins/ArchiveManifestTest.java b/plugins/src/test/java/org/tron/plugins/ArchiveManifestTest.java
@@ -16,8 +16,8 @@
 import java.util.UUID;
 
 import lombok.extern.slf4j.Slf4j;
-import org.iq80.leveldb.DB;
 import org.junit.AfterClass;
+import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
@@ -58,27 +58,27 @@ public static void destroy() {
   }
 
   @Test
-  public void testMain() {
+  public void testRun() {
     String[] args = new String[] { "-d", OUTPUT_DIRECTORY };
-    ArchiveManifest.main(args);
+    Assert.assertEquals(0, ArchiveManifest.run(args));
   }
 
   @Test
   public void testHelp() {
     String[] args = new String[] {"-h"};
-    ArchiveManifest.main(args);
+    Assert.assertEquals(0, ArchiveManifest.run(args));
   }
 
   @Test
   public void testMaxManifest() {
     String[] args = new String[] {"-d", OUTPUT_DIRECTORY, "-m", "128"};
-    ArchiveManifest.main(args);
+    Assert.assertEquals(0, ArchiveManifest.run(args));
   }
 
   @Test
   public void testNotExist() {
     String[] args = new String[] {"-d", OUTPUT_DIRECTORY + File.separator + UUID.randomUUID()};
-    ArchiveManifest.main(args);
+    Assert.assertEquals(404, ArchiveManifest.run(args));
   }
 
   @Test
@@ -87,7 +87,7 @@ public void testEmpty() {
     file.mkdirs();
     file.deleteOnExit();
     String[] args = new String[] {"-d", file.toString()};
-    ArchiveManifest.main(args);
+    Assert.assertEquals(0, ArchiveManifest.run(args));
   }
 
   private static void writeProperty(String filename, String key, String value) throws IOException {
