remove bm resize interface

ray6080 · ray6080 · commit f285b9639653 · 2023-03-15T11:15:04.000-04:00
diff --git a/src_cpp/include/py_database.h b/src_cpp/include/py_database.h
@@ -17,8 +17,6 @@ class PyDatabase {
 
     explicit PyDatabase(const std::string& databasePath, uint64_t bufferPoolSize);
 
-    void resizeBufferManager(uint64_t newSize);
-
     ~PyDatabase() = default;
 
 private:
diff --git a/src_cpp/py_database.cpp b/src_cpp/py_database.cpp
@@ -6,7 +6,6 @@ void PyDatabase::initialize(py::handle& m) {
     py::class_<PyDatabase>(m, "Database")
         .def(py::init<const std::string&, uint64_t>(), py::arg("database_path"),
             py::arg("buffer_pool_size") = 0)
-        .def("resize_buffer_manager", &PyDatabase::resizeBufferManager, py::arg("new_size"))
         .def("set_logging_level", &PyDatabase::setLoggingLevel, py::arg("logging_level"));
 }
 
@@ -20,7 +19,3 @@ PyDatabase::PyDatabase(const std::string& databasePath, uint64_t bufferPoolSize)
     }
     database = std::make_unique<Database>(databasePath, systemConfig);
 }
-
-void PyDatabase::resizeBufferManager(uint64_t newSize) {
-    database->resizeBufferManager(newSize);
-}
diff --git a/test/test_df.py b/test/test_df.py
@@ -69,13 +69,6 @@ def _test_to_df(conn):
     conn.set_max_threads_for_exec(1)
     _test_to_df(conn)
 
-    db.resize_buffer_manager(384 * 1024 * 1024)
-    _test_to_df(conn)
-
-    db.resize_buffer_manager(512 * 1024 * 1024)
-    conn.set_max_threads_for_exec(4)
-    _test_to_df(conn)
-
     db.set_logging_level("debug")
     _test_to_df(conn)
 
diff --git a/test/test_exception.py b/test/test_exception.py
@@ -13,10 +13,6 @@ def test_exception(establish_connection):
     with pytest.raises(RuntimeError, match="Binder exception: Cannot find property dummy for a."):
         conn.execute("MATCH (a:person) RETURN a.dummy;")
 
-    with pytest.raises(RuntimeError,
-                       match="Buffer manager exception: Resizing to a smaller Buffer Pool Size is unsupported."):
-        db.resize_buffer_manager(1)
-
 
 def test_db_path_exception():
     path = '/:* /? " < > |'

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ void PyDatabase::initialize(py::handle& m) {`
`6`	`6`	`py::class_<PyDatabase>(m, "Database")`
`7`	`7`	`.def(py::init<const std::string&, uint64_t>(), py::arg("database_path"),`
`8`	`8`	`py::arg("buffer_pool_size") = 0)`
`9`		`- .def("resize_buffer_manager", &PyDatabase::resizeBufferManager, py::arg("new_size"))`
`10`	`9`	`.def("set_logging_level", &PyDatabase::setLoggingLevel, py::arg("logging_level"));`
`11`	`10`	`}`
`12`	`11`
`@@ -20,7 +19,3 @@ PyDatabase::PyDatabase(const std::string& databasePath, uint64_t bufferPoolSize)`
`20`	`19`	`}`
`21`	`20`	`database = std::make_unique<Database>(databasePath, systemConfig);`
`22`	`21`	`}`
`23`		`-`
`24`		`-void PyDatabase::resizeBufferManager(uint64_t newSize) {`
`25`		`- database->resizeBufferManager(newSize);`
`26`		`-}`