Fix add-function

acquamarin · acquamarin · commit 3ced480a0e70 · 2023-11-18T13:21:16.000-05:00
diff --git a/src_cpp/py_database.cpp b/src_cpp/py_database.cpp
@@ -35,7 +35,7 @@ PyDatabase::PyDatabase(const std::string& databasePath, uint64_t bufferPoolSize,
     uint64_t maxNumThreads, bool compression, bool readOnly) {
     auto systemConfig = SystemConfig(bufferPoolSize, maxNumThreads, compression, readOnly);
     database = std::make_unique<Database>(databasePath, systemConfig);
-    database->addFunction(READ_PANDAS_FUNC_NAME,kuzu::PandasScanFunction::getFunctionSet());
+    database->addBuiltInFunction(READ_PANDAS_FUNC_NAME, kuzu::PandasScanFunction::getFunctionSet());
     storageDriver = std::make_unique<kuzu::main::StorageDriver>(database.get());
 }
 
diff --git a/test/test_scan_pandas.py b/test/test_scan_pandas.py
@@ -62,6 +62,8 @@ def test_scan_pandas_with_filter(get_tmp_path):
         'weight': np.array([23.2, 31.7, 42.9], dtype=np.float64)
     }
     df = pd.DataFrame(data)
+    # Dummy query to ensure the READ_PANDAS function is persistent after a write transaction.
+    conn.execute("CREATE NODE TABLE PERSON1(ID INT64, PRIMARY KEY(ID))")
     results = conn.execute("CALL READ_PANDAS('df') WHERE id > 20 RETURN id + 5, weight")
     assert results.get_next() == [27, 23.2]
     assert results.get_next() == [105, 42.9]

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ PyDatabase::PyDatabase(const std::string& databasePath, uint64_t bufferPoolSize,`
`35`	`35`	`uint64_t maxNumThreads, bool compression, bool readOnly) {`
`36`	`36`	`auto systemConfig = SystemConfig(bufferPoolSize, maxNumThreads, compression, readOnly);`
`37`	`37`	`database = std::make_unique<Database>(databasePath, systemConfig);`
`38`		`- database->addFunction(READ_PANDAS_FUNC_NAME,kuzu::PandasScanFunction::getFunctionSet());`
	`38`	`+ database->addBuiltInFunction(READ_PANDAS_FUNC_NAME, kuzu::PandasScanFunction::getFunctionSet());`
`39`	`39`	`storageDriver = std::make_unique<kuzu::main::StorageDriver>(database.get());`
`40`	`40`	`}`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ def test_scan_pandas_with_filter(get_tmp_path):`
`62`	`62`	`'weight': np.array([23.2, 31.7, 42.9], dtype=np.float64)`
`63`	`63`	`}`
`64`	`64`	`df = pd.DataFrame(data)`
	`65`	`+ # Dummy query to ensure the READ_PANDAS function is persistent after a write transaction.`
	`66`	`+ conn.execute("CREATE NODE TABLE PERSON1(ID INT64, PRIMARY KEY(ID))")`
`65`	`67`	`results = conn.execute("CALL READ_PANDAS('df') WHERE id > 20 RETURN id + 5, weight")`
`66`	`68`	`assert results.get_next() == [27, 23.2]`
`67`	`69`	`assert results.get_next() == [105, 42.9]`