cmake: enable Wextra

Keenan Gugeler · Riolku · commit e36c54107a5f · 2023-12-04T18:34:07.000-05:00
Primarily these warnings fall into two categories:
- Unused parameter (that clang-tidy didn't catch).
- Mismatch sign comparison. Generally this happens in loops, and the
  correct fix is `auto i = 0u`. This gives `i` the type of `unsigned`,
  and so we must be careful that `i` cannot overflow 2^32.

Wextra is disabled when building third_party code.
diff --git a/src_cpp/include/node_query_result.h b/src_cpp/include/node_query_result.h
@@ -98,7 +98,7 @@ class NodeQueryResultGetNextAsyncWorker : public Napi::AsyncWorker {
         Napi::Object nodeTuple = Napi::Object::New(env);
         try {
             auto columnNames = nodeQueryResult->queryResult->getColumnNames();
-            for (auto i = 0; i < cppTuple->len(); ++i) {
+            for (auto i = 0u; i < cppTuple->len(); ++i) {
                 Napi::Value value = Util::ConvertToNapiObject(*cppTuple->getValue(i), env);
                 nodeTuple.Set(columnNames[i], value);
             }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ class NodeQueryResultGetNextAsyncWorker : public Napi::AsyncWorker {`
`98`	`98`	`Napi::Object nodeTuple = Napi::Object::New(env);`
`99`	`99`	`try {`
`100`	`100`	`auto columnNames = nodeQueryResult->queryResult->getColumnNames();`
`101`		`- for (auto i = 0; i < cppTuple->len(); ++i) {`
	`101`	`+ for (auto i = 0u; i < cppTuple->len(); ++i) {`
`102`	`102`	`Napi::Value value = Util::ConvertToNapiObject(*cppTuple->getValue(i), env);`
`103`	`103`	`nodeTuple.Set(columnNames[i], value);`
`104`	`104`	`}`