replace std::assert with KU_ASSERT

Keenan Gugeler · Riolku · commit a083d6a094f2 · 2023-11-06T14:31:17.000-05:00
This also enables a parameter RUNTIME_CHECKS that can be passed to the Makefile to force these checks to be on. This also enables a CI check to make sure we consistently use KU_ASSERT and not std::assert.

Closes #2283.
diff --git a/src_cpp/node_util.cpp b/src_cpp/node_util.cpp
@@ -167,8 +167,8 @@ std::unordered_map<std::string, std::shared_ptr<Value>> Util::TransformParameter
     std::unordered_map<std::string, std::shared_ptr<Value>> result;
     for (size_t i = 0; i < params.Length(); i++) {
         auto param = params.Get(i).As<Napi::Array>();
-        assert(param.Length() == 2);
-        assert(param.Get(uint32_t(0)).IsString());
+        KU_ASSERT(param.Length() == 2);
+        KU_ASSERT(param.Get(uint32_t(0)).IsString());
         auto key = param.Get(uint32_t(0)).ToString().Utf8Value();
         if (!parameterMap.count(key)) {
             throw Exception("Parameter " + key + " is not defined in the prepared statement");
