tidy: enable performance checks

Keenan Gugeler · Riolku · commit 4b661e47e663 · 2023-11-27T21:37:38.000-05:00
With the exception of performance-no-int-to-ptr, this change enables
clang tidy's performance-based lints.

The changes made are as follows, in no particular order.

- Avoid std::endl. std::endl is confusing because it also flushes the
  buffer, which is often undesirable. Instead, we should just use a newline
  character.
- When possible, declare variables as `const T&amp;` instead of `T`, since
  it avoids a copy.
- When possible, use `std::move` to avoid a copy. However, if the type
  is trivially copyable, `std::move` does nothing and hence should be
  removed. Furthermore, if the variable to be moved is constant,
  `std::move` simply copies, and so `std::move` is confusing and should
  be removed. Finally, if the variable is moved, but the function
  parameter type is `const T&amp;`, then a move is unnecessary, and again,
  it should be removed.
- When using `push_back` in a loop, we should reserve up front for
  better performance.
- When concatenating strings, either we should `std::move()` the
  strings, or use `string::append`. Otherwise, we pay the price of
  creating temporary strings, instead of just pushing to a single
  string.
- Trivial destructors should be declared with `= default` to allow more
  aggressive compiler optimizations.
diff --git a/src_cpp/include/node_connection.h b/src_cpp/include/node_connection.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include <utility>
+
 #include "main/kuzu.h"
 #include "node_database.h"
 #include "node_prepared_statement.h"
@@ -64,7 +66,7 @@ class ConnectionExecuteAsyncWorker : public Napi::AsyncWorker {
     ConnectionExecuteAsyncWorker(Napi::Function& callback, std::shared_ptr<Connection>& connection,
         std::shared_ptr<PreparedStatement> preparedStatement, NodeQueryResult* nodeQueryResult,
         std::unordered_map<std::string, std::unique_ptr<Value>> params)
-        : Napi::AsyncWorker(callback), preparedStatement(preparedStatement),
+        : Napi::AsyncWorker(callback), preparedStatement(std::move(preparedStatement)),
           nodeQueryResult(nodeQueryResult), connection(connection), params(std::move(params)) {}
     ~ConnectionExecuteAsyncWorker() override = default;
 
